Skip to content

[backport v2.14.5] [Automation] - Fix imported generic cluster e2e failures - #18715

Open
izaac wants to merge 1 commit into
rancher:release-2.14from
izaac:issue-2488-2.14
Open

[backport v2.14.5] [Automation] - Fix imported generic cluster e2e failures#18715
izaac wants to merge 1 commit into
rancher:release-2.14from
izaac:issue-2488-2.14

Conversation

@izaac

@izaac izaac commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This is a backport of #18713 to release-2.14.

The redirect problem in #18712 does not happen on this branch, so the create test still asserts the redirect here. The table of contents test does not exist on this branch either. Everything else is the same as on master.


Summary

Fixes rancher/qa-tasks#2488
Fixes rancher/qa-tasks#2462
Fixes rancher/qa-tasks#2463

Occurred changes and/or fixed issues

  • Fixed the whole Imported.Generic block, the three tests were failing before they reached anything they were meant to cover
  • Stopped waiting on the #registration fragment, the registration tab is now selected explicitly
  • Moved timeouts onto the commands that actually yield the element, several were silently inactive
  • Test only changes, no product code affected

Technical notes summary

  • #registration is not written by the router, it is a side effect of Tabbed picking a default tab, which happens once while no tab is active. The registration tab only exists after the registration token resolves, so if the token is slow another tab wins and the fragment never appears. A longer timeout cannot fix that ordering
  • Cypress timeouts are per command, so a timeout given to rowWithName() did not carry over to column(), which fell back to the 10s default. Threaded the options through
  • .should() reads its second argument as the assertion message, so timeouts passed there were ignored
  • The waiting state assertion now runs before the registration manifest is applied, where no agent can have connected yet. After the apply it is a race
  • The import button is now found by its own test id. It was found by position, which resolves to the create button whenever the import button is hidden

Testing done

The failures also needed an infrastructure fix, the imported cluster's k3s was advertising its public IP so CoreDNS could never reach the API server and the cluster never went active. That is rancher/qa-infra-automation#159.

With that in place this block goes from 3 failures to a full pass, 3/3 in 53 seconds.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@izaac izaac added this to the v2.14.5 milestone Aug 7, 2026
@izaac
izaac force-pushed the issue-2488-2.14 branch from 221d82b to 5fca3d6 Compare August 7, 2026 00:42
The tests in the Imported block were failing before they reached anything they were meant to cover. Absorb the cold start of the dynamically imported list component in a before hook, select the registration tab explicitly rather than waiting for the `#registration` fragment that Tabbed only writes as a side effect of picking a default tab, assert the intermediate waiting state before the registration manifest is applied rather than after, move timeouts off `should()` where they were read as the assertion message and onto the commands that yield the element, thread them through `ListRowPo.column` so they survive narrowing a row to a cell, and target the import button by its own test id rather than by position in the masthead.
@izaac
izaac force-pushed the issue-2488-2.14 branch from 5fca3d6 to 7377c7a Compare August 7, 2026 00:46
@izaac izaac added QA/None QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Aug 7, 2026
@izaac izaac modified the milestones: v2.14.5, v2.16.0 Aug 7, 2026
@izaac izaac modified the milestones: v2.16.0, v2.14.5 Aug 7, 2026
@izaac
izaac marked this pull request as ready for review August 7, 2026 00:50
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🔄 Auto-Retry Failed Run

The Tests workflow failed for the commits below and has been automatically retried.
Follow up on a retried run through its link if needed.

Commit Workflow run Retried at
221d82b 31135221987 2026-08-07 01:07 UTC
5fca3d6 31135591577 2026-08-07 01:13 UTC
7377c7a 31135825312 2026-08-07 01:17 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/None

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant