Refactor sensor handling and remove timestamp from message headers#55
Merged
Merged
Conversation
This fixes an initialization issue in the bias_lock module caused by the unordered sensor ordering.
Contributor
|
I assume you are intending for this PR to resolve this issue: I cannot test this myself. It would be better if you could explain how you tested it - which would give the reviewer more confidence when merging the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated timestamp handling from frontend callbacks and refactor active sensor ordering.
The sensor initialization order is now deterministic to prevent failures in modules with dependencies on previously initialized parameters. In particular, bias_lock requires values initialized by the INS module, such as the INS frame, so an incorrect order could cause startup issues.