Skip to content

[Tests] redo spawning test (w/o AssetProcessor) - #1100

Merged
nick-l-o3de merged 1 commit into
o3de:developmentfrom
RobotecAI:jh/spawnable_test
Sep 23, 2026
Merged

nick-l-o3de merged 1 commit into
o3de:developmentfrom
RobotecAI:jh/spawnable_test

Conversation

@jhanca-robotecai

Copy link
Copy Markdown
Collaborator

What does this PR do?

SimulationInterfaces.Editor.Tests depended on ${PROJECT_NAME}.Assets just to get a processed .spawnable for SpawnAppTest. That target runs AssetProcessorBatch, which pulls the whole builder half of the engine into the CI build (EMotionFX.Editor, assimp, SceneAPI, the Atom .Builders modules, …). It was the only test target in o3de-extras or o3de that did this.

The test environment now assembles the spawnable in memory and registers it via AzFramework::InMemorySpawnableAssetContainer, as the Multiplayer gem does. The test body and its product_asset:///… URI are unchanged.

  • Code/CMakeLists.txt — drop ${PROJECT_NAME}.Assets, add the missing Gem::ROS2
  • delete Assets/SampleAsset/TestSimulationEntity.prefab — a test fixture that shipped to every project enabling the gem
  • simulation-gems-pr.yml — drop Ros2GemsTest.Assets from the build targets

How was this PR tested?

Tests built and ran locally.

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
@byrcolin byrcolin added the sig/simulation Categorizes an issue or PR as relevant to SIG Simulation label Sep 22, 2026
@jhanca-robotecai

jhanca-robotecai commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

The tests have passed, we can draw conclusions:

  ┌──────────────────────┬──────────────────────┬────────────────┬────────────────────┐
  │                      │ baseline 35629715056 │ PR 35734424880 │         Δ          │
  ├──────────────────────┼──────────────────────┼────────────────┼────────────────────┤
  │ Build step           │ 3h 22m 34s           │ 1h 29m 37s     │ −1h 52m 57s (−56%) │
  ├──────────────────────┼──────────────────────┼────────────────┼────────────────────┤
  │ Whole job            │ 3h 33m 37s           │ 1h 39m 27s     │ −54%               │
  ├──────────────────────┼──────────────────────┼────────────────┼────────────────────┤
  │ ninja edges          │ 5750                 │ 3523           │ −2227              │
  ├──────────────────────┼──────────────────────┼────────────────┼────────────────────┤
  │ CXX objects          │ 4898                 │ 3061           │ −1837              │
  ├──────────────────────┼──────────────────────┼────────────────┼────────────────────┤
  │ Asset Processor runs │ 1 (5m 22s)           │ 0              │ —                  │
  └──────────────────────┴──────────────────────┴────────────────┴────────────────────┘

@nick-l-o3de
nick-l-o3de merged commit f23e7ae into o3de:development Sep 23, 2026
3 checks passed
@jhanca-robotecai
jhanca-robotecai deleted the jh/spawnable_test branch September 24, 2026 08:46
jhanca-robotecai added a commit that referenced this pull request Oct 12, 2026
* Ability to get inertial property from AddToArticulationConfig (#1088)

Signed-off-by: welber-zhang <welber.zhang@huawei.com>
(cherry picked from commit bc9eb68)

* Added possibility to set history policy (#1098)

Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
(cherry picked from commit d7b3858)

* [MachineLearning] Update ScriptCanvas after engine changes (#1101)

* [MachineLearning] Update ScriptCanvas after engine changes

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>

* [MachineLearning] Fix build

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>

---------

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
(cherry picked from commit ee2ff33)

* [Tests] redo spawning test (w/o AssetProcessor) (#1100)

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
(cherry picked from commit f23e7ae)

* [ROS2RobotImporter] Add warning banner for registries and articulations (#1099)

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
(cherry picked from commit 2518837)

---------

Signed-off-by: welber-zhang <welber.zhang@huawei.com>
Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Co-authored-by: 张东 <welber.zhang@huawei.com>
Co-authored-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/simulation Categorizes an issue or PR as relevant to SIG Simulation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants