feat(federation): Federated table sharing - #2786
Conversation
403289e to
ba97e23
Compare
4da0386 to
35b4e5e
Compare
1bf2714 to
e948b30
Compare
8a02508 to
63c7628
Compare
Thanks for the feedback! After checking Deck's |
4beef8f to
a38af3d
Compare
a38af3d to
e6485cc
Compare
| namespace OCA\Tables\AppInfo; | ||
|
|
||
| use Exception; | ||
| use OC\OCM\OCMSignatoryManager; |
There was a problem hiding this comment.
Would be cool (and more sustainable) when there will be a public interface for this, but definitely out of scope for now, might be accompanied by an issue against server if there is not one yet.
(On second look it might be more complicated than that)
blizzz
left a comment
There was a problem hiding this comment.
some things that would be good to have, but no definite blocker by reading the code
| #[RequirePermission(permission: Application::PERMISSION_UPDATE, typeParam: 'nodeCollection')] | ||
| #[ApiRoute(verb: 'PUT', url: '/api/2/{nodeCollection}/{nodeId}/rows/{rowId}', requirements: ['nodeCollection' => '(tables|views)', 'nodeId' => '(\d+)'])] | ||
| public function updateRow(string $nodeCollection, int $nodeId, int $rowId, mixed $data): DataResponse { | ||
| if (is_string($data)) { |
There was a problem hiding this comment.
$data could be of type string|array then?
| } | ||
|
|
||
| public function notifyPermissionUpdate(Share $share): void { | ||
| $this->proxy->sendNotification( |
There was a problem hiding this comment.
what if any of those requests do not get through (maybe the remote nextcloud is being updated), will they be retried?
There was a problem hiding this comment.
Currently no retry mechanism, if the notification fails it is logged as a warning.
| <referencedClass name="Doctrine\DBAL\Types\Types" /> | ||
| <referencedClass name="OC\Core\Command\Base" /> | ||
| <referencedClass name="OC\Http\Client\Response" /> | ||
| <referencedClass name="OC\OCM\OCMSignatoryManager" /> |
| <referencedClass name="Doctrine\DBAL\Schema\Table" /> | ||
| <referencedClass name="Doctrine\DBAL\Types\Types" /> | ||
| <referencedClass name="OC\Core\Command\Base" /> | ||
| <referencedClass name="OC\Http\Client\Response" /> |
ac23763 to
6e4b66d
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com> # Conflicts: # lib/AppInfo/Application.php # psalm.xml
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
3bad71c to
aec831b
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
aec831b to
eb8eb93
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
aa3787c to
198e5a2
Compare
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
198e5a2 to
c0f2f78
Compare
… signature verification Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
|
[Follow up/General tech debt] One thing about Migrations, because i just stumbled across them recently, are the attributes. Can be added as followup, and I do not think we have them in place elsewhere. https://docs.nextcloud.com/server/latest/developer_manual/basics/storage/migrations.html#migrations-and-metadata |
Federated table sharing
Allows sharing tables with users on other Nextcloud instances.
Todo
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)