fix: throw FederationRequestError instead of generic Exception

Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>

Author: benjaminfrueh

lib/AppInfo/Application.php

@@ -50,10 +50,10 @@
 use OCP\Federation\ICloudFederationProvider;
 use OCP\Federation\ICloudFederationProviderManager;
 use OCP\Group\Events\GroupDeletedEvent;
+use OCP\Navigation\Events\LoadAdditionalEntriesEvent;
 use OCP\OCM\Events\LocalOCMDiscoveryEvent;
 use OCP\Security\Signature\ISignatoryManager;
 use OCP\Server;
-use OCP\Navigation\Events\LoadAdditionalEntriesEvent;
 use OCP\Share\ShareReview\RegisterShareReviewSourceEvent;
 use OCP\User\Events\BeforeUserDeletedEvent;
 use OCP\User\Events\UserDeletedEvent;

lib/Errors/FederationRequestError.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Tables\Errors;
+
+class FederationRequestError extends \Exception {
+}

lib/Federation/FederationProxy.php

@@ -13,6 +13,7 @@
 use GuzzleHttp\Exception\ServerException;
 use OC\Http\Client\Response;
 use OCA\Tables\Db\Share;
+use OCA\Tables\Errors\FederationRequestError;
 use OCP\AppFramework\Http;
 use OCP\Federation\ICloudFederationFactory;
 use OCP\Federation\ICloudFederationProviderManager;
@@ -70,7 +71,7 @@ protected function prependProtocolIfNotAvailable(string $url): string {
 
 	/**
 	 * @param 'get'|'post'|'put'|'delete' $verb
-	 * @throws \Exception
+	 * @throws FederationRequestError
 	 */
 	protected function request(
 		string $verb,
@@ -93,17 +94,16 @@ protected function request(
 			$body->rewind();
 
 			if (!is_array(json_decode($content, true))) {
-				throw new \Exception('Error parsing JSON response', $status);
+				throw new FederationRequestError('Error parsing JSON response', $status);
 			}
 
 			$this->logger->debug('Client error from remote', ['exception' => $e]);
 
 			/** @psalm-suppress InvalidReturnStatement */
 			return new Response($e->getResponse(), false);
 		} catch (ServerException|\Throwable $e) {
-			$serverException = new \Exception($e->getMessage(), $e->getCode(), $e);
-			$this->logger->error('Could not reach remote', ['exception' => $serverException]);
-			throw $serverException;
+			$this->logger->error('Could not reach remote', ['exception' => $e]);
+			throw new FederationRequestError('Could not reach remote: ' . $e->getMessage(), $e->getCode(), $e);
 		}
 	}
 
@@ -123,6 +123,9 @@ public function delete(string $shareToken, string $url): IResponse {
 		return $this->request('delete', $shareToken, $url);
 	}
 
+	/**
+	 * @throws FederationRequestError
+	 */
 	public function getOCSData(IResponse $response, array $allowedStatusCodes = [Http::STATUS_OK]): array {
 		if (!in_array($response->getStatusCode(), $allowedStatusCodes, true)) {
 			$this->logger->debug('Unexpected status code ' . $response->getStatusCode());
@@ -132,11 +135,11 @@ public function getOCSData(IResponse $response, array $allowedStatusCodes = [Htt
 			$content = $response->getBody();
 			$responseData = json_decode($content, true, flags: JSON_THROW_ON_ERROR);
 			if (!is_array($responseData)) {
-				throw new \RuntimeException('JSON response is not an array');
+				throw new FederationRequestError('JSON response is not an array');
 			}
 		} catch (\Throwable $e) {
 			$this->logger->error('Error parsing JSON response', ['exception' => $e]);
-			throw new \Exception('Error parsing JSON response', $e->getCode(), $e);
+			throw new FederationRequestError('Error parsing JSON response', $e->getCode(), $e);
 		}
 
 		return $responseData['ocs']['data'] ?? [];

lib/Middleware/ShareControlMiddleware.php

@@ -25,8 +25,8 @@
 use OCP\Federation\ICloudIdManager;
 use OCP\IRequest;
 use OCP\ISession;
-use OCP\Share\IManager as ShareManager;
 use OCP\OCM\IOCMDiscoveryService;
+use OCP\Share\IManager as ShareManager;
 use ReflectionMethod;
 
 class ShareControlMiddleware extends Middleware {

src/modules/sidebar/partials/ShareForm.vue

@@ -59,15 +59,16 @@ export default {
 		},
 	},
 
-	data() {
-		return {
-			selectedShare: null,
-		}
-	},
-
 	emits: [
 		'add',
 	],
+
+  data() {
+    return {
+      selectedShare: null,
+    }
+  },
+
 	computed: {
 		...mapState(useTablesStore, ['tables', 'showSidebar', 'isLoadingSomething']),