-
Notifications
You must be signed in to change notification settings - Fork 50
feat(federation): Federated table sharing #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7438480
feat(federation): federated table and view sharing
benjaminfrueh 00865d6
fix: when federation is disabled, local table APIs dont fail
samin-z f8e6900
fix: remove duplicate federation enabled checks
benjaminfrueh 4fb4b1f
fix: validate nodeType also on receiver side
benjaminfrueh 55bae93
fix: add declare strict to new files
benjaminfrueh eb8eb93
fix: throw FederationRequestError instead of generic Exception
benjaminfrueh 63f67ab
chore: update migration
benjaminfrueh c0f2f78
fix: send node uuid to receiving instance
benjaminfrueh 521099a
fix: implement ISignedCloudFederationProvider to fix OCM notification…
benjaminfrueh 3693248
Merge branch 'main' into feat/federated-sharing
blizzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,55 @@ | ||
| { | ||
| "id": 226, | ||
| "tableId": 49, | ||
| "createdBy": null, | ||
| "createdAt": null, | ||
| "lastEditBy": null, | ||
| "lastEditAt": null, | ||
| "data": [ | ||
| { | ||
| "columnId": 159, | ||
| "value": "Giraffe" | ||
| }, | ||
| { | ||
| "columnId": 160, | ||
| "value": "Mr. Smith" | ||
| }, | ||
| { | ||
| "columnId": 161, | ||
| "value": "Dog food every week" | ||
| }, | ||
| { | ||
| "columnId": 162, | ||
| "value": "2023-01-01" | ||
| }, | ||
| { | ||
| "columnId": 163, | ||
| "value": "2023-12-31" | ||
| }, | ||
| { | ||
| "columnId": 164, | ||
| "value": "The dog is our best friend." | ||
| }, | ||
| { | ||
| "columnId": 165, | ||
| "value": "Standard, SLA Level 2" | ||
| }, | ||
| { | ||
| "columnId": 166, | ||
| "value": 80 | ||
| }, | ||
| { | ||
| "columnId": 167, | ||
| "value": "Likes treats" | ||
| "ocs": { | ||
| "meta": { | ||
| "status": "ok", | ||
| "statuscode": 200, | ||
| "message": "OK" | ||
| }, | ||
| "data": { | ||
| "id": 226, | ||
| "tableId": 49, | ||
| "createdBy": null, | ||
| "createdAt": null, | ||
| "lastEditBy": null, | ||
| "lastEditAt": null, | ||
| "data": [ | ||
| { | ||
| "columnId": 159, | ||
| "value": "Giraffe" | ||
| }, | ||
| { | ||
| "columnId": 160, | ||
| "value": "Mr. Smith" | ||
| }, | ||
| { | ||
| "columnId": 161, | ||
| "value": "Dog food every week" | ||
| }, | ||
| { | ||
| "columnId": 162, | ||
| "value": "2023-01-01" | ||
| }, | ||
| { | ||
| "columnId": 163, | ||
| "value": "2023-12-31" | ||
| }, | ||
| { | ||
| "columnId": 164, | ||
| "value": "The dog is our best friend." | ||
| }, | ||
| { | ||
| "columnId": 165, | ||
| "value": "Standard, SLA Level 2" | ||
| }, | ||
| { | ||
| "columnId": 166, | ||
| "value": 80 | ||
| }, | ||
| { | ||
| "columnId": 167, | ||
| "value": "Likes treats" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\Tables\Config; | ||
|
|
||
| use OCP\Config\Lexicon\Entry; | ||
| use OCP\Config\Lexicon\ILexicon; | ||
| use OCP\Config\Lexicon\Strictness; | ||
| use OCP\Config\ValueType; | ||
|
|
||
| /** | ||
| * Config Lexicon for tables. | ||
| * | ||
| * Please Add & Manage your Config Keys in that file and keep the Lexicon up to date! | ||
| * | ||
| * {@see ILexicon} | ||
| */ | ||
| class ConfigLexicon implements ILexicon { | ||
| public const FEDERATION_ENABLED = 'federationEnabled'; | ||
|
|
||
| #[\Override] | ||
| public function getStrictness(): Strictness { | ||
| return Strictness::IGNORE; | ||
| } | ||
|
|
||
| #[\Override] | ||
| public function getAppConfigs(): array { | ||
| return [ | ||
| new Entry(self::FEDERATION_ENABLED, ValueType::BOOL, true, 'Enable or disable federated table sharing'), | ||
| ]; | ||
| } | ||
|
|
||
| #[\Override] | ||
| public function getUserConfigs(): array { | ||
| return []; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool (and more sustainable) when there will be a public interface for this, but definitely out of scope for now, might be accompanied by an issue against server if there is not one yet.
(On second look it might be more complicated than that)