Skip to content

fix(proposals): handle invalid timezone fallback - #8917

Merged
odzhychko merged 1 commit into
nextcloud:mainfrom
Kumar-s75:fix/proposal-invalid-timezone
Sep 10, 2026
Merged

odzhychko merged 1 commit into
nextcloud:mainfrom
Kumar-s75:fix/proposal-invalid-timezone

Conversation

@Kumar-s75

Copy link
Copy Markdown
Contributor

Summary

  • import the shared logger in the timezone offset service
  • preserve the intended UTC fallback when an invalid timezone is supplied
  • add a regression test for invalid timezone identifiers

Testing

npm run test:unit -- tests/javascript/unit/services/timezoneOffsetService.test.ts
npx eslint src/services/timezoneOffsetService.ts tests/javascript/unit/services/timezoneOffsetService.test.ts
git diff --check

All checks pass.

Closes #8914

Import the shared logger so invalid timezone identifiers fall back to UTC instead of throwing a secondary ReferenceError. Add a regression test for the fallback.

Closes nextcloud#8914

Assisted-by: Codex:gpt-5
Signed-off-by: Kumar Saurabh <kumarsaurabh27d@gmail.com>
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@odzhychko
odzhychko merged commit 3d5f608 into nextcloud:main Sep 10, 2026
32 checks passed
@odzhychko

Copy link
Copy Markdown
Contributor

/backport to stable6.6

@backportbot backportbot Bot added the backport-request A backport was requested for this pull request label Sep 10, 2026
@odzhychko

Copy link
Copy Markdown
Contributor

/backport to stable6.5

@backportbot backportbot Bot removed the backport-request A backport was requested for this pull request label Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meeting proposal view crashes when timezone identifier is invalid

2 participants