[stable6.5] fix(proposals): handle invalid timezone fallback - #8922
Merged
Merged
Conversation
Import the shared logger so invalid timezone identifiers fall back to UTC instead of throwing a secondary ReferenceError. Add a regression test for the fallback. Closes #8914 Assisted-by: Codex:gpt-5 Signed-off-by: Kumar Saurabh <kumarsaurabh27d@gmail.com>
odzhychko
force-pushed
the
backport/8917/stable6.5
branch
from
September 10, 2026 07:08
deff9b2 to
1408d9d
Compare
odzhychko
previously approved these changes
Sep 10, 2026
odzhychko
requested review from
odzhychko
and removed request for
odzhychko
September 10, 2026 07:09
odzhychko
marked this pull request as ready for review
September 10, 2026 07:10
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
September 10, 2026 07:10
odzhychko
dismissed
their stale review
September 10, 2026 07:11
Leaving for one the other reviewers as I modified the code now.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SebastianKrupinski
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8917
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.