Conversation
Kumar-s75
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
September 12, 2026 10:48
Import the logger used by the timezone offset error path and cover the UTC fallback with a regression test. Fixes nextcloud#8928 Signed-off-by: Kumar Saurabh <kumarsaurabh27d@gmail.com>
Kumar-s75
force-pushed
the
fix/proposal-timezone-logger
branch
from
September 12, 2026 11:21
3c466de to
b72b7bf
Compare
Contributor
|
Duplicate of #8917 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReferenceErrorTests
npm run test:unit -- tests/javascript/unit/services/timezoneOffsetService.test.ts --reporter=dotTZ=UTC npm run test:unit -- --reporter=dot(519 tests passed)npx eslint src/services/timezoneOffsetService.ts tests/javascript/unit/services/timezoneOffsetService.test.tsCloses #8928