fix(studio): native dark Advanced controls and consistent dedicated Studio/Inno icon

[masarray]

Operator's Windows UI issue

The physical operator reports black/unreadable text in Advanced and generic icon branding. main already gained real PTP Source/Follower/Monitor + smpSynch lab simulation UI and ABC right-click via merged PR #192/#193; do NOT duplicate or revert those changes. Older PR #190/#191 remain overlapping and are not a safe integration target.

Changes

• Reuse the existing dedicated assets/studio_icon artwork already reviewed in PR feat(studio): dedicated phasor icon for native GUI and Inno Setup #190; add its validated, multi-resolution ARStackStudio.ico blob to main source. CMake configure_file(COPYONLY) puts that exact same icon in the canonical Windows build output, existing Windows PE .rc embeds it in ARStackStudio.exe, and Inno's existing SetupIconFile={#STAGE_DIR}\\ARStackStudio.ico uses that same staged icon. Qt embeds the matching 192/512 px PNGs as resources and sets QGuiApplication::setWindowIcon. The public Workbench icon and stable v0.1.1 release stay unchanged.
• Introduce one StudioDarkCheckBox used by Timing advanced/VLAN/Pdelay and Waveform saturation controls, removing black-on-dark native checkbox text.
• Reuse StudioDarkComboBox for the Signals SCL selector and profile family, plus Device manual recovery port; adjust model delegate to combo.textAt(index) so list and QAbstractItemModel textRole are supported in one native dark dropdown.
• All model/controller/capture/serial/PTP/SV signal APIs untouched. This is presentation + native executable/installer branding only.

Acceptance

Require exact PR-head Qt/QML compilation, harness/lifecycle, native Windows PE/Inno installer clean installation/upgrade/uninstall, and final artifact icon provenance check before merge. Physical screenshot readability / right-click PTP and 4I4V acceptance still requires operator. No changes to experimental M3 PR #166 or public stable release.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T10:08:33.874210Z	3fe3128	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[masarray]

Final merged handoff — 2026-10-16 native lab UX / icon

Merged PR #194 into main@bcbebc32ad19836cfd79ab05c1dec73e295b8721. Merge code tree df12ccfaa76582fe87c589910ad152fd9f70d3c2 exactly matches tested PR head 4280d028df1ab6260f9dd378d218c51dd72e0a8a. All 11/11 exact-head checks SUCCESS: Studio native Windows preview/Inno installer, Qt harness, Windows lifecycle, firmware ESP32-P4, RC2 policy, names, and unrelated IED simulator release checks. Zero unresolved inline reviews.

What users now get (merged #192/#193/#194):

• One PTP role choice Source / Follower auto-discover / Monitor, on/off switch reflecting board-verified running state; STOP/Retry retained, no optimistic false green state when request rejected. L2 follower does not require user to type a "server" IP.
• smpSynch AUTO / 0 / 1 / 2 easy lab simulation controls, with device-reported SIMULATED flag vs measured; setting 1/2 does not discipline GPTimer or establish PTP↔SV phase lock; M3 PR M3C.1: bind SV sample-zero epochs to consecutive PTP seconds #166 stays Draft.
• Right-click magnitude Equal ABC values; right-click angle Equal ABC angles and Balance ABC 120°, neutral unchanged; single bounded validated 3-signal batch on live session.
• Advanced dark shared controls on Signal SCL/profile family, Device recovery port, Waveform CT stress, PTP Advanced/VLAN/Pdelay; consistent text contrast.
• Exact Studio-only artwork assets/studio_icon/ARStackStudio.ico, four frames 16/32/48/192, bundled portable 51,880B icon SHA256 2a35ebfefeb8bf9f8b8c47d06756b1f2a8dae0d9818900ecbfadb7203fa487fc; Qt PNG resources and embedded Win32 PE RT_ICON/RT_GROUP_ICON verified from actual portable executable. Inno setup references same staged icon.
• No protocol firmware changes specific to this PR. Stable public v0.1.1 release unchanged. PR feat(studio): dedicated phasor icon for native GUI and Inno Setup #190/Studio lab UX: PTP Source/Follower switch, smpSynch simulation, ABC quick actions, Studio icons #191 closed as superseded (not merged).

Verified installer handoff: Windows Native Preview Actions run 38885078144, artifact 12038934968, expires 2026-10-23T10:16:46Z. ARStack-Studio-Preview-win-x64-setup.exe SHA256 19551634a5444d25c020c54d897b4518701290990bb5dfcfd78deadb5d1e516e (30,908,024 bytes); portable SHA256 e75fb1432307b030f5111c87343a9467b710e6f990b214016ae3843b4c9bdc46. Zip SHA256SUMS verified. Provenance GUI/firmware source 4280d028df1ab6260f9dd378d218c51dd72e0a8a, firmware build ID 4280d028df1ab626, bundled firmware SHA256 c458c59817342aec60f961429483ed738f73c7f0ebf25c4896bbf94d45242d31, embedded binary ID matches manifest. publicRelease=false, embeddedExperimentalM3=false, ptpHardwareQualified=false.

Physical acceptance still required: Operator may install preview without reflashing already compatible verified ESP32-P4. Validate native Windows window/taskbar/installer icon; right-click active current/voltage ABC fields (Equal, Balance) while SMV running and verify Pcap waveform/phasor and atomic SET batch outcome; PTP switch Source ON/OFF with device TX counters and independent Analyzer PTP capture, Follower searching/receive lock only with an actual external GM, AUTO/forced smpSynch simulated on-wire flagged correctly; use Copy diagnostics on failure. Do not claim hardware PTP-to-SV epoch lock or certified 61850-9-3 conformance (M2/M3 open).