Skip to content

Studio lab UX: PTP Source/Follower switch, smpSynch simulation, ABC quick actions, Studio icons - #191

Closed
masarray wants to merge 13 commits into
mainfrom
feat/studio-lab-timing-ux-icons-abc-20261016
Closed

masarray wants to merge 13 commits into
mainfrom
feat/studio-lab-timing-ux-icons-abc-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Physical operator requirements — native Windows Studio, bench simulation

The operator has verified ESP32-P4 firmware update/reconnect and actual 4000fps SV + PTP L2 Announce/Sync/Follow_Up on a direct Intel I219 NIC. No actual PTP-to-SV sample phase lock has been proven. The user wants productive simulation controls (not excessive interlocks), legible native Qt UI, quick ABC editing, and the dedicated Studio application icon. Keep stable v0.1.1 and experimental M3 Draft PR #166 untouched.

Changes

  • PTP Timing: visible PTP on/off switch using existing START/STOP verified native session; one role picker Source · provide lab time / Follower · auto-discover GM / Monitor. No requirement to type a fake server address for normal Layer-2 multicast PTP. PTP role requests still pass through the sole existing bounded session controller.
  • SV output flag AUTO / 0 / 1 LOCAL simulated / 2 GLOBAL simulated moved from buried advanced area to a clearly labelled lab simulation section, with device-reported flag. 1/2 are explicitly labelled advertised metadata only and never equated to actually disciplining the SV GPTimer.
  • Main injector: right-click magnitude -> Equal Value A/B/C; right-click phase -> Equal Angle A/B/C or Balance ABC 120°, anchored at clicked phase. Neutral remains untouched, preserve existing per-signal validations and live setpoint writer; no firmware or packet-path changes.
  • Advanced window: remove duplicate frame/header, streamline tab names, larger default width, themed ComboBox/CheckBox on Timing/profile/device/wave controls to fix native white/black text and improve dark contrast.
  • Dedicated assets/studio_icon/favicon.ico reused consistently: Qt QIcon resource for taskbar/window, Windows EXE PE .rc and Inno Setup SetupIconFile / UninstallDisplayIcon. No change to Workbench icon files.
  • No new firmware flash/protocol APIs or changes to PTP M3 experimental, public stable v0.1.1, ESP32 firmware, sample counter or clock discipline.

Acceptance

Need exact-head Qt/QML compile and deterministic harness, genuine Windows Inno installer build/clean install/upgrade/uninstall, UI smoke verification. Then operator validates context menus while Running, PTP Off / Source / Follower / Stop with actual COM board, and smpSynch simulated metadata. The SOURCE PTP packets do NOT establish real 61850-9-3 conformance or smpCnt phase lock. Do not merge on failures.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T07:59:18.862983Z c9d5748 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9d5748df2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/arstack_studio/qml/Main.qml Outdated
Comment thread apps/arstack_studio/qml/PtpExpertPanel.qml Outdated

Copy link
Copy Markdown
Owner Author

Superseded by merged PR #192 (PTP Source/Follower/Monitor, smpSynch simulation 0/1/2, native ABC context actions and batch), PR #193 (reactive feedback and dark PTP controls), and PR #194 (verified-state PTP switch, remaining Advanced contrast, dedicated Studio/Inno icon). Main bcbebc3 contains those features with full exact-head CI green. Closing this alternative overlapping branch to avoid duplicate QML modules / reverting live session fixes; code history retained and public v0.1.1 untouched.

@masarray masarray closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant