Repository navigation
Conversation
…eamlined Advanced layout
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9d5748df2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Superseded by merged PR #192 (PTP Source/Follower/Monitor, smpSynch simulation 0/1/2, native ABC context actions and batch), PR #193 (reactive feedback and dark PTP controls), and PR #194 (verified-state PTP switch, remaining Advanced contrast, dedicated Studio/Inno icon). Main bcbebc3 contains those features with full exact-head CI green. Closing this alternative overlapping branch to avoid duplicate QML modules / reverting live session fixes; code history retained and public v0.1.1 untouched. |
Physical operator requirements — native Windows Studio, bench simulation
The operator has verified ESP32-P4 firmware update/reconnect and actual 4000fps SV + PTP L2 Announce/Sync/Follow_Up on a direct Intel I219 NIC. No actual PTP-to-SV sample phase lock has been proven. The user wants productive simulation controls (not excessive interlocks), legible native Qt UI, quick ABC editing, and the dedicated Studio application icon. Keep stable v0.1.1 and experimental M3 Draft PR #166 untouched.
Changes
Source · provide lab time / Follower · auto-discover GM / Monitor. No requirement to type a fake server address for normal Layer-2 multicast PTP. PTP role requests still pass through the sole existing bounded session controller.AUTO / 0 / 1 LOCAL simulated / 2 GLOBAL simulatedmoved from buried advanced area to a clearly labelled lab simulation section, with device-reported flag.1/2are explicitly labelled advertised metadata only and never equated to actually disciplining the SV GPTimer.assets/studio_icon/favicon.icoreused consistently: Qt QIcon resource for taskbar/window, Windows EXE PE .rc and Inno Setup SetupIconFile / UninstallDisplayIcon. No change to Workbench icon files.Acceptance
Need exact-head Qt/QML compile and deterministic harness, genuine Windows Inno installer build/clean install/upgrade/uninstall, UI smoke verification. Then operator validates context menus while Running, PTP Off / Source / Follower / Stop with actual COM board, and smpSynch simulated metadata. The SOURCE PTP packets do NOT establish real 61850-9-3 conformance or
smpCntphase lock. Do not merge on failures.