Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Superseded by the merged native Studio icon integration in PR #194 (main bcbebc3). The exact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Use the existing
assets/studio_icon/three-phase RYB artwork exclusively for ARStack Studio, without touching the Workbench branding in rootassets/.Changes
assets/studio_icon/ARStackStudio.icowith 16, 32, 48 and 192 px icon images; keep the original source files unchanged.ARStackStudio.exeusing CMake's Windows-only RC path.QGuiApplication::setWindowIconso Qt/QML windows display the icon.ARStackStudio.isswithSetupIconFileandUninstallDisplayIconfor Inno Setup stable/preview channels.Checks performed
assets/*Workbench files.CI / validation
Please allow existing native Windows preview workflow to compile the Qt executable and build/smoke the Inno installer. Local Windows Qt / Inno build not executed in this chat. No firmware behavior changes were made.
Note: The legacy stable release packaging workflow still uses NSIS; this PR targets the native Studio executable and the existing Inno Setup path only.