Skip to content

feat(studio): dedicated phasor icon for native GUI and Inno Setup - #190

Closed
masarray wants to merge 2 commits into
mainfrom
feat/studio-native-inno-icon-20261016
Closed

masarray wants to merge 2 commits into
mainfrom
feat/studio-native-inno-icon-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Purpose

Use the existing assets/studio_icon/ three-phase RYB artwork exclusively for ARStack Studio, without touching the Workbench branding in root assets/.

Changes

  • Generate assets/studio_icon/ARStackStudio.ico with 16, 32, 48 and 192 px icon images; keep the original source files unchanged.
  • Embed this icon as a Windows PE icon resource in ARStackStudio.exe using CMake's Windows-only RC path.
  • Register the Studio-only 192 and 512 px PNGs as Qt resources and set QGuiApplication::setWindowIcon so Qt/QML windows display the icon.
  • Configure ARStackStudio.iss with SetupIconFile and UninstallDisplayIcon for Inno Setup stable/preview channels.
  • Keep Windows icon branding independent from Workbench, browser favicons, runtime core, firmware, and any communication path.

Checks performed

  • Parsed output ICO directory; all 4 frames and data offsets are valid (192 px entry is PNG-backed).
  • Verified the Qt resource paths and Windows RC resource wiring are present.
  • Verified Inno Setup script points to the Studio-only icon, independent of invocation directory.
  • Confirmed there are no changes in root assets/* Workbench files.

CI / validation

Please allow existing native Windows preview workflow to compile the Qt executable and build/smoke the Inno installer. Local Windows Qt / Inno build not executed in this chat. No firmware behavior changes were made.

Note: The legacy stable release packaging workflow still uses NSIS; this PR targets the native Studio executable and the existing Inno Setup path only.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T06:30:31.381837Z 8a977bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Superseded by the merged native Studio icon integration in PR #194 (main bcbebc3). The exact assets/studio_icon/ARStackStudio.ico artwork is now committed and used by Qt window resources, embedded Windows EXE RT_ICON/RT_GROUP_ICON, and staged Inno Setup. Exact head #194 Windows preview CI, installer, lifecycle and build checks all PASS. Closing this overlapping branch to avoid regressing current packaging; no force-push or file deletion.

@masarray masarray closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant