Skip to content

Studio lab UX: ABC context shortcuts, readable PTP role controls and Advanced - #192

Merged
masarray merged 8 commits into
mainfrom
feat/studio-simulation-ptp-ux-fast-phase-icon-20261016
Oct 16, 2026
Merged

masarray merged 8 commits into
mainfrom
feat/studio-simulation-ptp-ux-fast-phase-icon-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Engineering preview only. Adds right-click Equal ABC Value, Equal ABC Angle and Balance ABC around selected phase with live setpoint updates through existing session; larger, more legible Advanced window; PTP mode labels Source/Follower/Monitor and themed menu. No changes to firmware/smpSynch truthfulness. Follow-ups: branded native Windows icon + Inno packaging; deeper timing controls. Keep Draft until installer CI and review.

@masarray
masarray marked this pull request as ready for review October 16, 2026 08:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T08:44:32.865081Z 62b10f0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62b10f0113

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/arstack_studio/qml/Main.qml Outdated
Comment thread apps/arstack_studio/qml/Main.qml Outdated
@masarray
masarray merged commit 3e7c216 into main Oct 16, 2026
10 checks passed

Copy link
Copy Markdown
Owner Author

Final engineering handoff — PR #192 merged 2026-10-16

  • Merge commit 3e7c216280ec922a23f3344802093bea5938124f, tree c4e92f190ec413d0607920f9116372b558071cf9 exactly equals tested final PR head 2e2e0dea3b581c4d201e22ed0b77421113debf83, both parents preserved.
  • CI 10/10 checks PASS on exact head: Qt build + S8 deterministic harness + offscreen and High DPI QML, Windows process lifecycle & ownership, firmware ESP32-P4, RC2 policy, routing/naming, native Windows preview + Inno migration.
  • Exact installer Windows Preview Actions #38877072515, artifact 12036501100, expires 2026-10-23 09:06 UTC. ARStack-Studio-Preview-win-x64-setup.exe SHA-256 1010aefe2e59ddcadc47327f89a0f20a9d4262b58925c73d90a20946924c27d9, bytes 30,516,673; ARStack-Studio-Preview-win-x64-portable.zip SHA-256 f7f4e1faf36744d2ab18f2566886a95cf2a2a0dbd2681d012bdfb850db07f91e.
  • Staged 6-size ARStackStudio.ico independently decoded as a valid ICO (16/24/32/48/64/128 px), SHA-256 cb292023cb103f3de89dadcea114755d27bceacc85f662babc59975fc9435457; source generator is stdlib-only and deterministic; icon embedded at Windows RC compile and reused by Inno setup / shell shortcuts; CI install/uninstall + NSIS stable migration PASSED.
  • Firmware manifest sourceCommit=2e2e0dea3b581c4d201e22ed0b77421113debf83, buildId=2e2e0dea3b581c4d, actual bundled firmware SHA256 cb3daa6282ffdd9b98a7585edd6a16f5f0601aff01f6be1a8631dfbee188a66f; preview provenance preserves publicRelease=false, ptpHardwareQualified=false, embeddedExperimentalM3=false.
  • Operator workflow: Advanced > Time Sync: Source/Follow external GM (automatic discovery)/Monitor, Start/Stop and Copy diagnostics; directly choose emitted smpSynch AUTO/0/1/2 for simulation. Forced values are marked SIMULATED by firmware, not falsely claimed as PTP phase lock. GUI offers right-click on ABC magnitude: Equal ABC values to selected channel; on angle: Equal ABC angles or Balance ABC angles (selected channel = anchor); neutral unchanged. Existing StudioDeviceController 20-ms coalescer submits all SETs via one bounded worker batch without partial serial enqueues even under saturation; review P1/P2 addressed and resolved. Advanced larger, dark Qt palette.
  • Pending physical tests: install this new Windows preview on operator PC, live right-click ABC transitions and subscriber analyzer waveform, PTP Source/Follower UI, simulation flag lab only. No physical PTP↔SV phase lock, external IED acceptance or synchronized timestamp conformance is claimed. M3 PR M3C.1: bind SV sample-zero epochs to consecutive PTP seconds #166 remains Draft, stable v0.1.1 release unchanged. No forced board reflash is required merely for cosmetic GUI testing if existing firmware is compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant