fix: Link libpsl static library for static builds - #4355
Merged
jjerphan merged 6 commits intoJul 31, 2026
Conversation
Member
|
Thanks for opening this. We also need a static build of ICU (a dependency of libpsl) to get it build (work in progress on conda-forge/icu-feedstock#50). |
Contributor
|
ICU is a very heavy dependency. I suggest building libpsl-static without ICU. |
Member
|
Thanks for the suggestion, I'll give it a try. |
This was referenced Jul 24, 2026
5 tasks
jjerphan
force-pushed
the
fix/static-libcurl-libpsl-linking
branch
from
July 30, 2026 11:52
ddd04a8 to
ac4f00a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4355 +/- ##
==========================================
+ Coverage 55.08% 55.39% +0.31%
==========================================
Files 240 243 +3
Lines 30329 30360 +31
Branches 3241 3253 +12
==========================================
+ Hits 16707 16819 +112
+ Misses 13619 13538 -81
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jjerphan
reviewed
Jul 30, 2026
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
fix/static-libcurl-libpsl-linking
branch
from
July 30, 2026 13:08
e860a1b to
7dcb66c
Compare
Require libpsl-static in the static env and CI (all platforms except win-arm64, where it is not published), and skip linking libpsl.a there.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
libpsl static library for static builds
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
JohanMabille
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upstreams this patch: conda-forge/micromamba-feedstock#304
Fixes issue seen here:
#4353 (comment)
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.