Skip to content

fix: Link libpsl static library for static builds - #4355

Merged
jjerphan merged 6 commits into
mamba-org:mainfrom
mikemhenry:fix/static-libcurl-libpsl-linking
Jul 31, 2026
Merged

fix: Link libpsl static library for static builds#4355
jjerphan merged 6 commits into
mamba-org:mainfrom
mikemhenry:fix/static-libcurl-libpsl-linking

Conversation

@mikemhenry

@mikemhenry mikemhenry commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Description

Upstreams this patch: conda-forge/micromamba-feedstock#304
Fixes issue seen here:
#4353 (comment)

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions Bot added the release::bug_fixes For PRs fixing bugs label Jul 22, 2026
@JohanMabille

Copy link
Copy Markdown
Member

Thanks for opening this. We also need a static build of ICU (a dependency of libpsl) to get it build (work in progress on conda-forge/icu-feedstock#50).

@isuruf

isuruf commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

ICU is a very heavy dependency. I suggest building libpsl-static without ICU.

@JohanMabille

Copy link
Copy Markdown
Member

Thanks for the suggestion, I'll give it a try.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.39%. Comparing base (6bf836f) to head (1841b15).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4355      +/-   ##
==========================================
+ Coverage   55.08%   55.39%   +0.31%     
==========================================
  Files         240      243       +3     
  Lines       30329    30360      +31     
  Branches     3241     3253      +12     
==========================================
+ Hits        16707    16819     +112     
+ Misses      13619    13538      -81     
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread libmamba/CMakeLists.txt Outdated
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
jjerphan force-pushed the fix/static-libcurl-libpsl-linking branch from e860a1b to 7dcb66c Compare July 30, 2026 13:08
mikemhenry and others added 3 commits July 30, 2026 15:50
Require libpsl-static in the static env and CI (all platforms except
win-arm64, where it is not published), and skip linking libpsl.a there.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan changed the title fix: link libpsl for static libcurl builds fix: Link libpsl static library for static builds Jul 31, 2026
jjerphan added 2 commits July 31, 2026 09:55
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
jjerphan merged commit 7f86ebf into mamba-org:main Jul 31, 2026
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants