Rebuild libcurl-static with libpsl-static - #172
Merged
h-vetinari merged 2 commits intoJul 30, 2026
Merged
Conversation
Define PSL_STATIC and link libpsl.a so static objects call psl_* instead of DLL imports (__imp_psl_*), which broke micromamba static linking.
jjerphan
requested review from
h-vetinari,
jakirkham,
mingwandroid,
msarahan,
ocefpaf and
xylar
as code owners
July 30, 2026 08:09
Member
Author
|
@conda-forge-admin, please rerender |
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jjerphan
changed the title
libcurl-static with libpsl-static
jjerphan
marked this pull request as draft
July 30, 2026 08:12
![conda-forge-webservices[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
…2026.07.29.10.37.2
jjerphan
marked this pull request as ready for review
July 30, 2026 08:24
h-vetinari
approved these changes
Jul 30, 2026
Member
|
LGTM, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)libcurl-staticagainstlibpsl-staticwith-DPSL_STATIC, so object files reference undecoratedpsl_*symbols instead of DLL imports (__imp_psl_*).LIBPSL_LIBRARYatlibpsl.a.This unblocks static micromamba linking on Windows (see mamba-org/mamba#4355 and conda-forge/micromamba-feedstock#304), where
libcurl_a.libcurrently fails with unresolved__imp_psl_*when linked withlibpsl.a.