No dependency on ICU for the static build - #21
Conversation
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/30079108921. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/30080659956. Examine the logs at this URL for more detail. |
eb1d394 to
8d6020a
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/30085132920. Examine the logs at this URL for more detail. |
49cbcbe to
f50416b
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
61e74f7 to
6f02ef2
Compare
|
@tschoonj this is ready for review. |
| run_exports: | ||
| - ${{ pin_subpackage('libpsl', exact=True) }} |
There was a problem hiding this comment.
Why do you need a run_exports for the static library?
There was a problem hiding this comment.
Because the headers are in the libpsl package, and there is no "host_export" feature in the conda ecosystem.. Not doing so would require any downstream package depending on libpsl-static to also depend on libpsl.
There was a problem hiding this comment.
You are conflating run vs run_exports.
There was a problem hiding this comment.
So we should add libpsl in the host section of packages depending on libpsl-static at build time (to get the headers), and ignore its run_exports (in order no to pull libpsl when installing a package depending on libpsl-static) ?
There was a problem hiding this comment.
Ah got it, sorry for the confusion.
Move 'pin_subpackage' from 'run_exports' to 'run' section.
As suggested in mamba-org/mamba#4355 (comment), we should build libpsl-static without depending on ICU. For now only micromamba indirecly depends on it (through libcurl, which does not use libpsl for IDNA / unicode support), so it is safe to build without ICU. If we need it in the future, we may want to build a variant since ICU is a heavy dependency.