Add 2.541.x line and remove 2.504.x - #6285
Conversation
Added 2.541.x line and removed 2.504.x
|
I am still seeing the failure due to version issues in the stack trace of the Console output00:57:06 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.6.2:enforce (display-info) on project gitea-checks: 00:57:06 [ERROR] Rule 1: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message: 00:57:06 [ERROR] Detected JDK /opt/jdk-17 is version 17.0.17 which is not in the allowed range [21,). 00:57:06 [ERROR] -> [Help 1] 00:57:06 org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.6.2:enforce (display-info) on project gitea-checks: 00:57:06 Rule 1: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message: 00:57:06 Detected JDK /opt/jdk-17 is version 17.0.17 which is not in the allowed range [21,). 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162) 00:57:06 at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159) 00:57:06 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105) 00:57:06 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73) 00:57:06 at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53) 00:57:06 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118) 00:57:06 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261) 00:57:06 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173) 00:57:06 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101) 00:57:06 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:919) 00:57:06 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:285) 00:57:06 at org.apache.maven.cli.MavenCli.main (MavenCli.java:207) 00:57:06 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) 00:57:06 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) 00:57:06 at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) 00:57:06 at java.lang.reflect.Method.invoke (Method.java:569) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314) 00:57:06 Caused by: org.apache.maven.plugin.MojoExecutionException: 00:57:06 Rule 1: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message: 00:57:06 Detected JDK /opt/jdk-17 is version 17.0.17 which is not in the allowed range [21,). 00:57:06 at org.apache.maven.plugins.enforcer.EnforceMojo.execute (EnforceMojo.java:272) 00:57:06 at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162) 00:57:06 at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39) 00:57:06 at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159) 00:57:06 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105) 00:57:06 at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73) 00:57:06 at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53) 00:57:06 at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118) 00:57:06 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261) 00:57:06 at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173) 00:57:06 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101) 00:57:06 at org.apache.maven.cli.MavenCli.execute (MavenCli.java:919) 00:57:06 at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:285) 00:57:06 at org.apache.maven.cli.MavenCli.main (MavenCli.java:207) 00:57:06 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) 00:57:06 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) 00:57:06 at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) 00:57:06 at java.lang.reflect.Method.invoke (Method.java:569) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361) 00:57:06 at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314) 00:57:06 [ERROR] 00:57:06 [ERROR] Re-run Maven using the -X switch to enable full debug logging. 00:57:06 [ERROR] 00:57:06 [ERROR] For more information about the errors and possible solutions, please read the following articles: 00:57:06 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException 00:57:06 org.jenkins.tools.test.exception.PomExecutionException: mvn -B -V -e -ntp -pl :gitea-checks -Dmaven.javadoc.skip=true clean process-test-classes in /home/jenkins/agent/workspace/Tools_bom_PR-6285/target/pct-work/gitea-checks-plugin failed with exit status 1 00:57:06 at org.jenkins.tools.test.maven.ExternalMavenRunner.run(ExternalMavenRunner.java:118) 00:57:06 at org.jenkins.tools.test.PluginCompatTester.testPluginAgainst(PluginCompatTester.java:267) 00:57:06 at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:163) 00:57:06 at org.jenkins.tools.test.PluginCompatTesterCli.call(PluginCompatTesterCli.java:209) 00:57:06 at org.jenkins.tools.test.PluginCompatTesterCli.call(PluginCompatTesterCli.java:44) 00:57:06 at picocli.CommandLine.executeUserObject(CommandLine.java:2031) 00:57:06 at picocli.CommandLine.access$1500(CommandLine.java:148) 00:57:06 at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2469) 00:57:06 at picocli.CommandLine$RunLast.handle(CommandLine.java:2461) 00:57:06 at picocli.CommandLine$RunLast.handle(CommandLine.java:2423) 00:57:06 at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277) 00:57:06 at picocli.CommandLine$RunLast.execute(CommandLine.java:2425) 00:57:06 at picocli.CommandLine.execute(CommandLine.java:2174) 00:57:06 at org.jenkins.tools.test.CLI.main(CLI.java:13) script returned exit code 1@viceice it looks like we will need to fix this up for the gitea-checks plugin and issue a new release. |
It may be possible to resolve it by downgrading the version of the analysis pom that is used in the gitea-checks plugin. Unfortunately, I won't have time to explore that idea until the weekend. We may need to accept that this week's release of the plugin BOM won't include Jenkins 2.541.1. That's not a big problem, since there are not likely to yet be many plugins that require 2.541.1 as their minimum Jenkins version. |
Was there a reason to not just continue in the original PR? |
|
No particular reason except because of an accident and also as a learning experience for @shalinisudarsan |
I believe it is because @shalinisudarsan did not have permission to modify the original pull request, since it was created by me. This is a pull request that she can modify. @krisstern and I can also modify it as maintainers of the plugin BOM. |
I am wrong. The original PR was created by @shalinisudarsan. My apologies for the mistake. |
if someone can tell me to which version to downgrade, then I can do it tomorrow. I don't know enough of Jenkins to understand the error. |
The gitea-checks plugin 601.607.vcea_0049b_27e5 is built to require a Java 21 compiler. The Jenkins plugin BOM intentionally checks that Java 17 still compiles and passes tests with Jenkins 2.504.x, 2.516.x, and 2.528.x. Java 17 is supported with all those versions of Jenkins. We'll need a new release of gitea-checks plugin 601. compiled with Java 17. Details are described below: I can duplicate the failure with the following steps: When I run those commands, it fails with the message: If I revert two commits that updated the parent pom, then I can again compile with Java 17. The commands I used to revert were: We need a new release of the gitea-checks plugin that starts from the 601.607.vcea_0049b_27e5 tag and removes the two updates to the parent pom. Once that new release is available, we'll need to update the bom-2.5416.x/pom.xml . The version number of the new release will look something like The idea is tested in a pull request: That pull request is targeting the |
|
I've converted the pull request to draft so that it won't be inadvertently merged with the incremental version of gitea-checks plugin that I included. Once @viceice releases the final version of 601.609.x, the pull request can be updated with that new version in the bom-2.516.x/pom.xml file and it can be changed to "ready for review". |
|
Same problem exists in the instant-messaging plugin. Pull request submitted to fix it: |
Parent pom 6.2108.v08c2b_01b_cf4d incorrectly forced Java 21 compilation. That breaks the plugin BOM. Use a newer version that works with Java 17. Detected in pull request: * jenkinsci/bom#6285 Testing done: * Confirmed that Java 17 compilation fails without this change * Confirmed that Java 17 compilation works with this change
|
The workflow job plugin has the same issue. Fixed in pull request: |
|
will have another look a little later, the PR contains a few unrelated charges. I'll split them into different prs |
fixed your PR, it targeted wrong branch, that's why it contained so many changes 😁 |
|
@uhafner Can you please publish a new analysis-pom version with the fixed parent pom. so it doesn't accidentially break again from renovate updates 😕 |
|
The analysis-pom main branch already contains changes that do not work with java 17, so if not absolutely necessary I would postpone that until I release the next version that solely is based on Java 21. |
|
new gitea-checks release: https://github.com/jenkinsci/gitea-checks-plugin/releases/tag/603.623.vb_a_78fa_50b_2c3 |
ok. I'm thinking of switching to the jenkins base plugin pom like the other plugins i maintain to simplify things. 🤔 |
Ah, I wasn't aware that someone else is using my parent pom 😄. |
I didn't added it, it was there as i'd become a maintainer (defacto the only active) |
Allows Jenkins plugin BOM to be released with a version of gitea-checks that compiles with Java 17 for the 2.516.x line in addition to the 2.528.x, 2.541.x, and weekly lines. More details available in pull request: * jenkinsci/bom#6285 Testing done: * Confirmed that tests pass with Java 17
Thanks, but the pull request definitely did not target the wrong branch. Unfortunately, the new release 603.623.vb_a_78fa_50b_2c3 may be helpful for the 2.528.x line, but it does not solve the problem for the 2.516.x line. It does not support the 2.516.x line because it requires Jenkins 2.528.3 or newer. Thankfully, the change that you made for 603.623.vb_a_78fa_50b_2c3 will allow a change that can then be used in a new release that supports Jenkins 2.516.3 or newer. I've submitted a pull request with that change. Please merge it and release a new version from the main line after merging pull request: |
Allows Jenkins plugin BOM to be released with a version of gitea-checks that compiles with Java 17 for the 2.516.x line in addition to the 2.528.x, 2.541.x, and weekly lines. More details available in pull request: * jenkinsci/bom#6285 Testing done: * Confirmed that tests pass with Java 17
Ah, i see now. sorry for confusion. PR merged and should be released in a few minutes 🤗 |
Updated to compile with Java 17 * #6285
Thanks very much! The PR to update update the plugin BOM with the new version is now in process as: |
…_ecf7d5 (#6299) * Update dependency io.jenkins.plugins:gitea-checks to v603.625.v731f4b_ecf7d5 * Use gitea-checks 603.625.v731f4b_ecf7d5 for 2.516.x line Updated to compile with Java 17 * #6285 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
…to v2.882.v5363d4fd02fb_ (jenkinsci#6292)" Failure discovered in the upgrade to 2.541.1 as part of pull request: * jenkinsci#6285 Fixed by instant messaging plugin pull request: * jenkinsci/instant-messaging-plugin#308 This reverts commit c6637ba.
…to v2.882.v5363d4fd02fb_ (#6292)" (#6303) Failure discovered in the upgrade to 2.541.1 as part of pull request: * #6285 Fixed by instant messaging plugin pull request: * jenkinsci/instant-messaging-plugin#308 This reverts commit c6637ba.
|
Thanks everyone for this PR, especialy @MarkEWaite! |
|
Was this supposed to be released with https://github.com/jenkinsci/bom/releases/tag/5983.v443959746f1f? |
No. The next weekly release of the plugin BOM (Jan 30, 2026 or Jan 31, 2026) will include it. We chose to not include it in the 5983.v443959746f1f release because we hoped that @jimklimov would release a new version of the instant-messaging plugin that would allow us to remove a revert of its latest upgrade. The fix that needs to be released for the instant-messaging plugin is in pull request: |
Added 2.541.x line and removed 2.504.x
Following up on #6198
Testing done
Submitter checklist