Skip to content

Restore Java 17 compile with parent pom 6.2116.v7501b_67dc517 - #741

Merged
timja merged 2 commits into
jenkinsci:masterfrom
MarkEWaite:restore-java-17-compile
Jan 23, 2026
Merged

Restore Java 17 compile with parent pom 6.2116.v7501b_67dc517#741
timja merged 2 commits into
jenkinsci:masterfrom
MarkEWaite:restore-java-17-compile

Conversation

@MarkEWaite

@MarkEWaite MarkEWaite commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Restore Java 17 compile with parent pom 6.2116.v7501b_67dc517

Parent pom 6.2108.v08c2b_01b_cf4d incorrectly forced Java 21 compilation. That breaks the plugin BOM. Use a newer version that compiles with Java 17.

Detected in pull request:

Also tests with Java 17, since we've seen a bug in the parent pom that causes us to use the wrong compiler.

Testing done

  • Confirmed that Java 17 compilation fails without this change
  • Confirmed that Java 17 compilation works with this change

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Parent pom 6.2108.v08c2b_01b_cf4d incorrectly forced Java 21 compilation.
That breaks the plugin BOM.  Use a newer version that works with Java 17.

Detected in pull request:

* jenkinsci/bom#6285

Testing done:

* Confirmed that Java 17 compilation fails without this change

* Confirmed that Java 17 compilation works with this change
Was not necessary previously, but since we've seen a bug in the parent
pom that causes us to use the wrong compiler, let's test with Java 17.
@MarkEWaite
MarkEWaite requested a review from a team as a code owner January 23, 2026 05:08
MarkEWaite added a commit to shalinisudarsan/bom that referenced this pull request Jan 23, 2026
@timja
timja merged commit b423c25 into jenkinsci:master Jan 23, 2026
18 checks passed
@MarkEWaite
MarkEWaite deleted the restore-java-17-compile branch January 23, 2026 16:32
MarkEWaite added a commit to jenkinsci/bom that referenced this pull request Jan 24, 2026
* Add 2.541.x line and remove 2.504.x

Added 2.541.x line and removed 2.504.x

* Test gitea-checks 601.609.v7b_5ee1a_655f2 incremental

Built from pull request:

* jenkinsci/gitea-checks-plugin#307

* Update final release of 2.504.x line

* Use instant-messaging incremental 2.884.veda_553935c84

From pull request:

* jenkinsci/instant-messaging-plugin#308

* Use workflow-job incremental 1572.v4a_176c455367

Pull request:

* jenkinsci/workflow-job-plugin#741

* Document the final release for 2.504.x line

* Fix a merge mistake

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants