Skip to content

Use parent pom 6.2116.x to fix plugin BOM - #308

Merged
jimklimov merged 2 commits into
jenkinsci:masterfrom
MarkEWaite:allow-java-17-compile
Jan 30, 2026
Merged

Use parent pom 6.2116.x to fix plugin BOM#308
jimklimov merged 2 commits into
jenkinsci:masterfrom
MarkEWaite:allow-java-17-compile

Conversation

@MarkEWaite

@MarkEWaite MarkEWaite commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Use parent pom 6.2116.x to fix plugin BOM

Fixes the bug that was introduced in 6.2108.v08c2b_01b_cf4d. Java 21 was required in that pom. That requirement was incorrect. It has been repaired in more recent versions of the parent pom.

Detected in plugin BOM pull request:

We need a release quickly so that we can update the plugin BOM to include Jenkins 2.541.1.

Also tests with Java 17. Was not needed in the past because we didn't make the mistake of prematurely requiring Java 21. Since that mistake has been made, let's include Java 17 in the testing.

Also tests with Jenkins 2.541.1 and Java 25, since that is the most recent LTS.

Testing done

  • Confirmed that the plugin fails to compile with Java 17 unless this change is applied
  • Confirmed that once this change is applied, the plugin compiles with Java 17

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Fixes the bug that was introduced in 6.2108.v08c2b_01b_cf4d.  Java 21
was required in that pom.  That requirement was incorrect.  It has been
repaired in more recent versions of the parent pom.

Detected in plugin BOM pull request:

* jenkinsci/bom#6285

We need a release quickly so that we can update the plugin BOM to include
Jenkins 2.541.1.

Testing done:

* Confirmed that the plugin fails to compile with Java 17 unless this
  change is applied

* Confirmed that once this change is applied, the plugin compiles with
  Java 17
Was not needed in the past because we didn't make the mistake of
prematurely requiring Java 21.  Since that mistake has been made, let's
include Java 17 in the testing.

Also tests with Jenkins 2.541.1 and Java 25, since that is the most
recent LTS.
@MarkEWaite
MarkEWaite requested a review from a team as a code owner January 23, 2026 04:57
MarkEWaite added a commit to shalinisudarsan/bom that referenced this pull request Jan 23, 2026
@MarkEWaite

Copy link
Copy Markdown
Contributor Author

@jimklimov we need a new release of the plugin with this change or we need to drop the instant-messaging plugin from the plugin BOM. Can you label this pull request as "bug" and merge it so that a new release is generated?

MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Jan 24, 2026
…to v2.882.v5363d4fd02fb_ (jenkinsci#6292)"

Failure discovered in the upgrade to 2.541.1 as part of pull request:

* jenkinsci#6285

Fixed by instant messaging plugin pull request:

* jenkinsci/instant-messaging-plugin#308

This reverts commit c6637ba.
MarkEWaite added a commit to jenkinsci/bom that referenced this pull request Jan 24, 2026
…to v2.882.v5363d4fd02fb_ (#6292)" (#6303)

Failure discovered in the upgrade to 2.541.1 as part of pull request:

* #6285

Fixed by instant messaging plugin pull request:

* jenkinsci/instant-messaging-plugin#308

This reverts commit c6637ba.
MarkEWaite added a commit to jenkinsci/bom that referenced this pull request Jan 24, 2026
* Add 2.541.x line and remove 2.504.x

Added 2.541.x line and removed 2.504.x

* Test gitea-checks 601.609.v7b_5ee1a_655f2 incremental

Built from pull request:

* jenkinsci/gitea-checks-plugin#307

* Update final release of 2.504.x line

* Use instant-messaging incremental 2.884.veda_553935c84

From pull request:

* jenkinsci/instant-messaging-plugin#308

* Use workflow-job incremental 1572.v4a_176c455367

Pull request:

* jenkinsci/workflow-job-plugin#741

* Document the final release for 2.504.x line

* Fix a merge mistake

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
@MarkEWaite MarkEWaite changed the title Fix plugin BOM by using parent pom 6.2116.v7501b_67dc517 Use parent pom 6.2116.x to fix plugin BOM Jan 26, 2026
@jimklimov
jimklimov merged commit 1e66747 into jenkinsci:master Jan 30, 2026
18 checks passed
@MarkEWaite
MarkEWaite deleted the allow-java-17-compile branch February 18, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants