Skip to content

fix(schema): allow disabling automatic task outputs - #12797

Draft
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:schema/task-outputs-auto
Draft

fix(schema): allow disabling automatic task outputs#12797
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:schema/task-outputs-auto

Conversation

@risu729

@risu729 risu729 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Splits the task-output compatibility fix from #12521 into an independently reviewable schema change.

Change

The parser accepts outputs = { auto = false } and treats it as disabled automatic output tracking. The schema previously allowed only true; this models the full boolean contract and documents what false means.

Scope

Related split PRs

No merge order is required.

Validation

  • mise run render:schema
  • Schema and Prettier checks scoped to schema/mise.json and schema/mise-task.json
  • The original combined change passed mise run test:e2e e2e/config/test_schema_tombi and mise run lint-fix before splitting.

AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.

Entire-Checkpoint: 01M1Q6TEBA2TGR9MG0X7P7M07J
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: a64847ff-1e9f-4e23-8523-7b93fd70989e

📥 Commits

Reviewing files that changed from the base of the PR and between e2925ed and 1b2e75b.

📒 Files selected for processing (2)
  • schema/mise-task.json
  • schema/mise.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR broadens the task-output schema so outputs.auto accepts both boolean values and documents false as disabling automatic tracking.

  • Updates both the full configuration schema and standalone task schema.
  • The newly documented opt-out conflicts with runtime behavior when tasks inherit global inputs.

Confidence Score: 4/5

The PR is not safe to merge until auto = false reliably suppresses automatic output tracking or the accepted and documented contract is narrowed.

The schema now validates an explicit opt-out, but runtime deserialization collapses it into unspecified outputs and inherited inputs can turn automatic tracking back on.

Files Needing Attention: schema/mise-task.json, schema/mise.json

Important Files Changed

Filename Overview
schema/mise-task.json Allows outputs.auto = false, although runtime input expansion can subsequently reactivate automatic output tracking.
schema/mise.json Mirrors the standalone task-schema change and exposes the same schema/runtime contract mismatch.

Reviews (1): Last reviewed commit: "fix(schema): allow disabling automatic t..." | Re-trigger Greptile

Comment thread schema/mise-task.json
Comment on lines +178 to 179
"description": "automatically touch an internal tracked file instead of specifying outputs (false disables auto tracking)",
"type": "boolean"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 False Can Reactivate Tracking

When a task inherits nonempty global inputs without declaring its own sources, outputs = { auto = false } becomes an empty output list. Input expansion then treats the outputs as unspecified and enables automatic tracking. The schema therefore accepts and documents an opt-out that does not actually disable tracking for this configuration. The same issue is present in schema/mise.json:3278-3279.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 2 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant