fix(schema): allow disabling automatic task outputs - #12797
Conversation
Entire-Checkpoint: 01M1Q6TEBA2TGR9MG0X7P7M07J
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR broadens the task-output schema so
Confidence Score: 4/5The PR is not safe to merge until The schema now validates an explicit opt-out, but runtime deserialization collapses it into unspecified outputs and inherited inputs can turn automatic tracking back on. Files Needing Attention: schema/mise-task.json, schema/mise.json Important Files Changed
Reviews (1): Last reviewed commit: "fix(schema): allow disabling automatic t..." | Re-trigger Greptile |
| "description": "automatically touch an internal tracked file instead of specifying outputs (false disables auto tracking)", | ||
| "type": "boolean" |
There was a problem hiding this comment.
When a task inherits nonempty global inputs without declaring its own sources, outputs = { auto = false } becomes an empty output list. Input expansion then treats the outputs as unspecified and enables automatic tracking. The schema therefore accepts and documents an opt-out that does not actually disable tracking for this configuration. The same issue is present in schema/mise.json:3278-3279.
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 2 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
Splits the task-output compatibility fix from #12521 into an independently reviewable schema change.
Change
The parser accepts
outputs = { auto = false }and treats it as disabled automatic output tracking. The schema previously allowed onlytrue; this models the full boolean contract and documents whatfalsemeans.Scope
main.Related split PRs
No merge order is required.
Validation
mise run render:schemaschema/mise.jsonandschema/mise-task.jsonmise run test:e2e e2e/config/test_schema_tombiandmise run lint-fixbefore splitting.AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.