fix(schema): allow structured task array entries - #12796
Conversation
Entire-Checkpoint: 01M1Q6S3K0EN2GFF2AH4XK10G1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe task schemas now allow task arrays to contain script strings, task references with optional arguments and environment variables, and parallel task groups through the shared ChangesTask schema updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Task arrays can now validate structured task references and parallel groups alongside existing script strings. The schema changes are aligned across both published schemas, with no current merge-blocking risk identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR aligns task-array schema validation with the runtime’s existing structured
Confidence Score: 5/5The schema-only change appears safe to merge, with no actionable correctness, security, or repository-rule issues identified. The expanded schema variants map directly to the runtime’s accepted Important Files Changed
Reviews (1): Last reviewed commit: "fix(schema): allow structured task array..." | Re-trigger Greptile |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 2 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
Splits structured task-array entries from #12521 into an independently reviewable schema change.
Change
The task parser accepts full
RunEntryvalues inside task arrays, including task-reference tables withtask,args, andenv. The schema previously limited array items to strings. Point array items at the existingtask_run_entrydefinition.Scope
main.Related split PRs
No merge order is required.
Validation
mise run render:schemaschema/mise.jsonandschema/mise-task.jsonmise run test:e2e e2e/config/test_schema_tombiandmise run lint-fixbefore splitting.AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.
Summary by CodeRabbit