Skip to content

fix(schema): allow structured task array entries - #12796

Draft
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:schema/task-run-entries
Draft

fix(schema): allow structured task array entries#12796
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:schema/task-run-entries

Conversation

@risu729

@risu729 risu729 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Splits structured task-array entries from #12521 into an independently reviewable schema change.

Change

The task parser accepts full RunEntry values inside task arrays, including task-reference tables with task, args, and env. The schema previously limited array items to strings. Point array items at the existing task_run_entry definition.

Scope

Related split PRs

No merge order is required.

Validation

  • mise run render:schema
  • Schema and Prettier checks scoped to schema/mise.json and schema/mise-task.json
  • The original combined change passed mise run test:e2e e2e/config/test_schema_tombi and mise run lint-fix before splitting.

AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.

Summary by CodeRabbit

  • New Features
    • Task lists now support both scripts and task references.
    • Task references can include optional arguments and environment settings.
    • Parallel task groups are supported within task lists.

Entire-Checkpoint: 01M1Q6S3K0EN2GFF2AH4XK10G1
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: 3f362e1e-48e9-48fd-826b-898d0b9ad1e2

📥 Commits

Reviewing files that changed from the base of the PR and between e2925ed and dc493fb.

📒 Files selected for processing (2)
  • schema/mise-task.json
  • schema/mise.json

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The task schemas now allow task arrays to contain script strings, task references with optional arguments and environment variables, and parallel task groups through the shared task_run_entry definition.

Changes

Task schema updates

Layer / File(s) Summary
Task array entry contract
schema/mise-task.json, schema/mise.json
The task array item schema now references task_run_entry. The definition supports script strings, task references with optional args and env, and parallel task groups. The array description now reflects these supported entries.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dc493

Task arrays can now validate structured task references and parallel groups alongside existing script strings. The schema changes are aligned across both published schemas, with no current merge-blocking risk identified.

Suggested reviewers: jdx, jambalaya56562, marukome0743

Poem

A rabbit checks the schema bright
Scripts and task groups hop in sight
Args and env join the run
Parallel tasks race for fun
One shared entry keeps things right

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main schema change: allowing structured entries in task arrays.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR aligns task-array schema validation with the runtime’s existing structured RunEntry support.

  • Allows task arrays to contain scripts, single-task references, and parallel task groups.
  • Reuses the existing task_run_entry definition in both published schemas.
  • Keeps the generated task-only schema consistent with its reference-driven definition ordering.

Confidence Score: 5/5

The schema-only change appears safe to merge, with no actionable correctness, security, or repository-rule issues identified.

The expanded schema variants map directly to the runtime’s accepted RunEntry variants, both JSON references are valid, and the generated task schema’s definition ordering matches the renderer’s traversal behavior.

Important Files Changed

Filename Overview
schema/mise-task.json Updates generated task-array items to reference the complete run-entry schema and relocates the newly reachable definition into generator discovery order.
schema/mise.json Broadens task-array validation from string-only entries to the existing structured run-entry definition.

Reviews (1): Last reviewed commit: "fix(schema): allow structured task array..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 2 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant