Skip to content

fix(schema): model ignored rust cache verify - #12795

Draft
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:schema/rust-cache-verify
Draft

fix(schema): model ignored rust cache verify#12795
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:schema/rust-cache-verify

Conversation

@risu729

@risu729 risu729 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Splits the Rust-cache compatibility field from #12521 into an independently reviewable schema change.

Change

The task parser still accepts rust_cache.verify for compatibility. Because rust_cache is deprecated and unused, the schema marks verify as deprecated and accurately describes it as ignored in both task-property contexts.

Scope

Related split PRs

No merge order is required.

Validation

  • mise run render:schema
  • Schema and Prettier checks scoped to schema/mise.json and schema/mise-task.json
  • The original combined change passed mise run test:e2e e2e/config/test_schema_tombi and mise run lint-fix before splitting.

AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.

Summary by CodeRabbit

  • Compatibility
    • Configuration schemas now accept the deprecated rust_cache.verify option for compatibility.
    • The option defaults to false and is ignored because rust_cache is no longer used.

Entire-Checkpoint: 01M1Q6VVB34CZ13E0J24HV3FY1
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: d763754f-ab6b-44aa-b2cd-1b48cefcd70e

📥 Commits

Reviewing files that changed from the base of the PR and between e2925ed and 73589c3.

📒 Files selected for processing (2)
  • schema/mise-task.json
  • schema/mise.json

Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The schemas now accept a deprecated rust_cache.verify boolean property. The property defaults to false and is documented as ignored for compatibility.

Changes

Rust cache schema compatibility

Layer / File(s) Summary
Add deprecated verify property
schema/mise-task.json, schema/mise.json
The rust_cache object variants accept the deprecated verify boolean with a default of false. The schema documents that the value is accepted for compatibility and ignored.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 73589

This change allows deprecated rust_cache.verify configuration values to validate while documenting that they are ignored. No current merge-blocking risk remains.

Suggested reviewers: jdx, jambalaya56562, marukome0743

Poem

A rabbit checks the schema bright
verify rests at false tonight
Deprecated, yet welcomed through
Compatibility holds true
Rust cache sleeps; the fields align

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the schema change that models the ignored rust_cache.verify field.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the task schemas to recognize the legacy rust_cache.verify compatibility field while clearly marking it deprecated and ignored.

  • Adds the same boolean compatibility property to both task-property contexts in schema/mise.json.
  • Adds the property to the standalone task schema.
  • Keeps schema validation aligned with the existing task parser without changing runtime behavior.

Confidence Score: 5/5

The PR appears safe to merge because the schema additions consistently reflect existing parser behavior.

No actionable failures remain; the field’s placement, type, default, deprecation status, and ignored behavior align with the parser and current schema-rendering workflow.

Important Files Changed

Filename Overview
schema/mise-task.json Adds an accurate deprecated schema entry for the ignored rust_cache.verify compatibility field.
schema/mise.json Adds the same compatibility entry consistently to both task schema contexts.

Reviews (1): Last reviewed commit: "fix(schema): model ignored rust cache ve..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 2 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant