fix(schema): model ignored rust cache verify - #12795
Conversation
Entire-Checkpoint: 01M1Q6VVB34CZ13E0J24HV3FY1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe schemas now accept a deprecated ChangesRust cache schema compatibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change allows deprecated rust_cache.verify configuration values to validate while documenting that they are ignored. No current merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR updates the task schemas to recognize the legacy
Confidence Score: 5/5The PR appears safe to merge because the schema additions consistently reflect existing parser behavior. No actionable failures remain; the field’s placement, type, default, deprecation status, and ignored behavior align with the parser and current schema-rendering workflow. Important Files Changed
Reviews (1): Last reviewed commit: "fix(schema): model ignored rust cache ve..." | Re-trigger Greptile |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 2 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
Splits the Rust-cache compatibility field from #12521 into an independently reviewable schema change.
Change
The task parser still accepts
rust_cache.verifyfor compatibility. Becauserust_cacheis deprecated and unused, the schema marksverifyas deprecated and accurately describes it as ignored in both task-property contexts.Scope
main.Related split PRs
No merge order is required.
Validation
mise run render:schemaschema/mise.jsonandschema/mise-task.jsonmise run test:e2e e2e/config/test_schema_tombiandmise run lint-fixbefore splitting.AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.
Summary by CodeRabbit
rust_cache.verifyoption for compatibility.falseand is ignored becauserust_cacheis no longer used.