fix: collapse Slack notification jobs into helm-deploy steps - #120
Merged
Conversation
The deploy workflow graph showed five Slack jobs (slack-pending, slack-pending-notify, prepare-slack, slack-notify, slack-approved-react) as skipped boxes on every run without Slack enabled. - Merge pending-approval check, message build and post into a single slack-pending job using the gha-slack composite actions. It must stay a separate job: the environment approval gate blocks helm-deploy's steps, so a pre-approval notification cannot run inside it. - Move the approval reaction and deploy status message into conditional steps in helm-deploy. - Make Slack failures non-blocking via continue-on-error, so a Slack outage no longer fails a successful deploy. Inputs, outputs and the secrets: inherit requirement are unchanged.
Contributor
Author
Contributor
Author
|
Byggefeilen kan fikses hvis #121 merges først :) |
Follow-up to the job collapse, addressing review findings: - Bound each external Slack call with timeout-minutes: 1 so a hung or retrying Slack API (gha-slack defaults to ~5 retries over 5 min) cannot consume the deploy/rollback timeout budget. - Add continue-on-error to the status-message builder and gate the result post on its success, so a Slack-side failure can never fail an otherwise-successful deploy. - Warn (::warning::) when a deploy-status or approval notification fails or returns an empty message_ts, surfacing otherwise-silent channel / token / bot-invite misconfiguration.
alovh
approved these changes
Jul 2, 2026
Contributor
Author
|
@alovh 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy workflow graph showed five Slack jobs (slack-pending, slack-pending-notify, prepare-slack, slack-notify, slack-approved-react) as skipped boxes on every run without Slack enabled.
Inputs, outputs and the secrets: inherit requirement are unchanged.