chore: run amazing-app-containers fixture pod as uid 101 - #121
Merged
Conversation
henrik242
force-pushed
the
fix/containers-fixture-uid
branch
from
June 15, 2026 07:22
5ac9368 to
7699729
Compare
henrik242
force-pushed
the
fix/containers-fixture-uid
branch
from
June 16, 2026 10:24
7699729 to
5b188d5
Compare
The common chart's containers-array path ignores uid in containers[] entries; the pod securityContext only reads container.uid (singular) and fell back to the default 1000, which getting-started:latest cannot run as. This made test-deploy-ok-gcp-containers crash-loop and fail CI on every PR since the container_name feature was released in 1.6.0 (the feature's own PR ran the pre-release helm-deploy@v1 action, so the test never actually exercised the replacement). Also fix the rollback CI test, which broke once the containers test passed and CI progressed to it. The test calls the helm-deploy composite action directly, which bypasses deploy.yml's set-values-file step, so the values input stayed at its literal default "values" and the bad-image deploy failed on a missing env/values file instead of on the bad image. No failed revision was created, so the rollback was non-deterministic (status 2 vs 3) depending on leftover revisions in the shared amazing-app release. Resolve the dev values file explicitly so the deploy fails on the bad image and rolls back to the healthy previous revision (status 2). Assert status 2 (was a stale status 3 left over from the deleted helm-deploy@negative_test action branch), restore the test-deploy-gcp-with-rollback job name, and make cleanup idempotent with --ignore-not-found.
henrik242
force-pushed
the
fix/containers-fixture-uid
branch
from
June 17, 2026 10:17
5b188d5 to
f4e60c5
Compare
alovh
approved these changes
Jun 29, 2026
Contributor
Author
|
@alovh 🙇🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common chart's containers-array path ignores uid in containers[] entries; the pod securityContext only reads container.uid (singular) and fell back to the default 1000, which getting-started:latest cannot run as. This made test-deploy-ok-gcp-containers crash-loop and fail CI on every PR since the container_name feature was released in 1.6.0 (the feature's own PR ran the pre-release helm-deploy@v1 action, so the test never actually exercised the replacement).
This fixes the root cause for the failing #120 (https://github.com/entur/gha-helm/actions/runs/27414274923/job/81022995404)