fix(common): honor uid per entry in the containers list - #261
Open
henrik242 wants to merge 1 commit into
Open
Conversation
uid set on containers[] entries was silently ignored: the pod securityContext only read container.uid (singular) and fell back to the default 1000, and the per-container securityContext never set runAsUser. Pods using the containers list always ran as uid 1000. The pod securityContext (incl. fsGroup) now follows the first container entry's uid, and each entry's uid renders as runAsUser/runAsGroup on its own container. Same fix applied to cron.yaml. Single-container pods run as the same uid as before; the only rendered change is that each container's securityContext now also spells out runAsUser/runAsGroup (previously only the pod-level securityContext did).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uid set on containers[] entries was silently ignored: the pod securityContext only read container.uid (singular) and fell back to the default 1000, and the per-container securityContext never set runAsUser. Pods using the containers list always ran as uid 1000.
The pod securityContext (incl. fsGroup) now follows the first container entry's uid, and each entry's uid renders as runAsUser/runAsGroup on its own container. Same fix applied to cron.yaml. Single-container pods run as the same uid as before; the only rendered change is that each container's securityContext now also spells out runAsUser/runAsGroup (previously only the pod-level securityContext did).
This fixes the root cause for the failing entur/gha-helm#120 (https://github.com/entur/gha-helm/actions/runs/27414274923/job/81022995404)