Bump CI node to 16 to fix danger_babel_test test - #1393
Merged
Conversation
> error workbox-webpack-plugin@6.6.1: The engine "node" is incompatible with this module. Expected version ">=16.0.0". Got "14.21.3" > error Found incompatible module. - https://github.com/danger/danger-js/actions/runs/5706662040/job/15462583894?pr=1392#step:17:152
This was referenced Jul 30, 2023
Contributor
Author
|
This is easy change to fix failing CI. Probably proper solution would be to pin some packages. Create lockfile to track them. Or just override node version for the failing |
Contributor
Author
|
trying to use older create_react_app gives this error (and there is no global package installed) |
Contributor
Author
|
could be reproduced with npx: |
Member
|
Thanks, yeah, this seems good to me 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: There's alternative solution: #1394