Skip to content

CI: Split integration tests to own workflow - #1394

Closed
glensc wants to merge 3 commits into
danger:mainfrom
glensc:split-create-react-app
Closed

CI: Split integration tests to own workflow#1394
glensc wants to merge 3 commits into
danger:mainfrom
glensc:split-create-react-app

Conversation

@glensc

@glensc glensc commented Jul 30, 2023

Copy link
Copy Markdown
Contributor

Split CI file to be able override it with node 16.
Alternative fix to #1393

create-react-app doesn't allow running other versions than latest, and latest 5.0.1 requires node 16:

@glensc
glensc force-pushed the split-create-react-app branch from 6cfddab to 187e014 Compare July 30, 2023 15:55
@glensc
glensc marked this pull request as ready for review July 30, 2023 15:55
@glensc glensc changed the title CI: Split create_react_app test CI: Split integration tests to own workflow Jul 30, 2023
glensc added 2 commits July 30, 2023 18:56
Split CI file to be able override it with node 16
@glensc

glensc commented Jul 30, 2023

Copy link
Copy Markdown
Contributor Author

@fbartho @orta this is to fix CI. See also the other solution:

Merge which one suits you more.

@orta

orta commented Jul 31, 2023

Copy link
Copy Markdown
Member

Opted to go with #1393 - thanks!

@orta orta closed this Jul 31, 2023
@glensc

glensc commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

825d797 should be cherry-picked to some other branch

@glensc

glensc commented Apr 12, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-picked into a fresh pr:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants