Skip to content

Refactor: Put long node error inside html details - #1392

Merged
orta merged 2 commits into
danger:mainfrom
glensc:log-details
Jul 31, 2023
Merged

Refactor: Put long node error inside html details#1392
orta merged 2 commits into
danger:mainfrom
glensc:log-details

Conversation

@glensc

@glensc glensc commented Jul 30, 2023

Copy link
Copy Markdown
Contributor

when node process errors, that huge dump of details is placed as a note. put it into HTML <details> so the code block is collapsed by default.

image

@glensc

glensc commented Jul 30, 2023

Copy link
Copy Markdown
Contributor Author

@orta

orta commented Jul 31, 2023

Copy link
Copy Markdown
Member

Cool, yeah, this seems reasonable to me 👍🏻

@orta
orta merged commit c561731 into danger:main Jul 31, 2023
@glensc
glensc deleted the log-details branch July 31, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants