feat: bring SolidSyslog into the build, nothing wired yet - #28
Merged
Conversation
SolidSyslog enters the build and its lwIP adapter pack compiles against our lwipopts.h under our warning bar, but no application code calls into either yet. --gc-sections strips all of it, so the cost above the frozen baseline is 0 bytes on every axis — flash, RAM, heap, and both task stacks. That zero is the point: linking a platform pack you do not call is free, and the measurement is honest enough to show it. Three lines carry it. FetchContent nests the library under this build. SOLIDSYSLOG_PLATFORMS states the platforms rather than letting the library infer them from whatever the environment exports — lwIP alone, because nothing at this stage reaches any other pack. Then one link line for the Core library plus the pack. Getting to three lines took two fixes in the library, both found by this build being its first consumer from outside its own repository: it could not be used as a CMake subproject at all, and platform packs could only be selected by environment variables a real integrator would not have. Without the second, Core would also have shipped without its senders for a selection like this one. Pinned to a commit because the library has no release tag yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe build now fetches and links SolidSyslog with the LwipRaw backend. README.md and run-report.md update the linked-stage description, cost table, mbedTLS measurements, and self-check references. ChangesSolidSyslog linking and measurements
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 29, 2026
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this stage adds
SolidSyslog enters the CMake build and its lwIP adapter pack compiles against our
lwipopts.h, butno application code calls into either yet.
--gc-sectionsstrips all of it, so the cost above thefrozen baseline is 0 bytes on every axis — flash, RAM, heap and both task stacks.
That zero is the point: linking a platform pack you do not call is free, and the measurement is
honest enough to show it.
Checklist
the build, kept apart from any wiring step so a non-CMake integrator can discard it whole.
(The template's "application-only" wording does not fit this one stage; noted rather than
ticked falsely.)
measurements/linked.csvcommitted, and a row added tomeasurements/stages.tsv.python3 scripts/gen-cost-table.py../run.shgreen (build + QEMU + baseline self-check) —run-report.mdcommitted.Context for review: this is 1 of 21 sequential single-commit PRs replaying the integration on
top of the Baseline root. Each lands green and reviewed before the next is built on it, because a
change to an early commit would force every commit above it to be re-run and re-measured.
Summary by CodeRabbit
New Features
Documentation