feat: create the logger, wired to nothing, and watch it say so - #30
Merged
Conversation
The logger is created with both collaborators absent, deliberately. Create never fails and never returns NULL — a missing collaborator is substituted with its Null object — so the only evidence is what the handler prints, and the run report now carries three of them: [syslog] CRITICAL SolidSyslog bad-config (detail 1) [syslog] CRITICAL SolidSyslog bad-config (detail 2) [syslog] CRITICAL SolidSyslog bad-config (detail 3) Flash +1,036 B RAM +180 B Doing it in this order is the point. An integrator who wires everything at once and sees nothing cannot tell a working logger from a silent one; seeing the faults first, and then watching them go quiet as collaborators arrive, is the difference between believing it works and knowing. NULL is "not supplied" and is reported. A collaborator deliberately done without is passed as its Null object instead — the library tells those two apart, and so should anyone reading this wiring later. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe application adds a syslog wrapper that creates an empty ChangesLogger creation wiring
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant main
participant Syslog
participant SolidSyslog
main->>Syslog: Syslog_Start()
Syslog->>SolidSyslog: SolidSyslog_Create(config)
SolidSyslog-->>Syslog: shared logger instance
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this stage adds
The logger is created with both collaborators absent, deliberately. Create never
fails and never returns NULL — a missing collaborator is substituted with its
Null object — so the only evidence is what the handler prints, and the run report
now carries three of them:
[syslog] CRITICAL SolidSyslog bad-config (detail 1)
[syslog] CRITICAL SolidSyslog bad-config (detail 2)
[syslog] CRITICAL SolidSyslog bad-config (detail 3)
Flash +1,036 B
RAM +180 B
Doing it in this order is the point. An integrator who wires everything at once
and sees nothing cannot tell a working logger from a silent one; seeing the
faults first, and then watching them go quiet as collaborators arrive, is the
difference between believing it works and knowing.
NULL is "not supplied" and is reported. A collaborator deliberately done without
is passed as its Null object instead — the library tells those two apart, and so
should anyone reading this wiring later.
Files
Checklist
measurements/logger.csvcommitted.measurements/stages.tsv.python3 scripts/gen-cost-table.py../run.shgreen (build + QEMU + baseline self-check) —run-report.mdcommitted.Context for review: 3 of 21 sequential single-commit PRs replaying the integration on top of the Baseline root. Each lands green and reviewed before the next is built on it, because a change to an early commit would force every commit above it to be re-run and re-measured.
Summary by CodeRabbit
New Features
Documentation