feat: number every record with a meta sequenceId - #33
Conversation
<134>1 ... solid-syslog-example - BOOT [meta sequenceId="1"] device started Flash +6,032 B (+932 on the previous stage) RAM +436 B (+64) The counter increments once per record *formatted*, not per record delivered. A record that never reaches the collector therefore leaves a gap in the sequence rather than no trace at all — which is the whole value of the field, and the reason it lands before the circular buffer rather than after it. Instrument first, then introduce the failure mode; the other order means asserting a drop you already caused. The first SD-ELEMENT also introduces the rule that governs the rest: unlike a header field, an SD PARAM has no NILVALUE, so an unset one is omitted entirely rather than written as "-". Atomics joins the platform list. It is named but not linked — a platform over a stable system API is already inside libSolidSyslog.a, and adding a SolidSyslog::Atomics link target fails the configure with "target was not found". Only the header-configured packs have one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe example adds Atomics platform support, wires persistent ChangesSequence ID integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
run-report.md (1)
50-64: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winExercise sequence progression in the self-check.
The report only proves that the first formatted record contains
sequenceId="1"; it does not verify that a subsequent formatted record receives the next ID. Add a two-record check (or a deterministic test) that parses and compares both sequence IDs.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@run-report.md` around lines 50 - 64, The self-check currently validates only the first formatted record’s sequence ID. Extend the report validation around the formatted-record parsing to generate or parse two consecutive records, extract both sequence IDs, and assert they progress from 1 to 2 (or compare against the expected deterministic sequence), while preserving the existing first-record and measurement checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@run-report.md`:
- Around line 50-64: The self-check currently validates only the first formatted
record’s sequence ID. Extend the report validation around the formatted-record
parsing to generate or parse two consecutive records, extract both sequence IDs,
and assert they progress from 1 to 2 (or compare against the expected
deterministic sequence), while preserving the existing first-record and
measurement checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: db8363f3-3fc4-41da-ba1f-4f004951277e
⛔ Files ignored due to path filters (2)
measurements/sequence-id.csvis excluded by!**/*.csvmeasurements/stages.tsvis excluded by!**/*.tsv
📒 Files selected for processing (4)
CMakeLists.txtREADME.mdapp/syslog/Syslog.crun-report.md
Pull request
What this stage adds
<134>1 ... solid-syslog-example - BOOT [meta sequenceId="1"] device started
Flash +6,032 B (+932 on the previous stage)
RAM +436 B (+64)
The counter increments once per record formatted, not per record delivered. A
record that never reaches the collector therefore leaves a gap in the sequence
rather than no trace at all — which is the whole value of the field, and the
reason it lands before the circular buffer rather than after it. Instrument
first, then introduce the failure mode; the other order means asserting a drop
you already caused.
The first SD-ELEMENT also introduces the rule that governs the rest: unlike a
header field, an SD PARAM has no NILVALUE, so an unset one is omitted entirely
rather than written as "-".
Atomics joins the platform list. It is named but not linked — a platform over a
stable system API is already inside libSolidSyslog.a, and adding a
SolidSyslog::Atomics link target fails the configure with "target was not found".
Only the header-configured packs have one.
Files
Checklist
measurements/sequence-id.csvcommitted.measurements/stages.tsv.python3 scripts/gen-cost-table.py../run.shgreen (build + QEMU + baseline self-check) —run-report.mdcommitted.Context for review: 6 of 21 sequential single-commit PRs replaying the integration on top of the Baseline root. Each lands green and reviewed before the next is built on it, because a change to an early commit would force every commit above it to be re-run and re-measured.
Summary by CodeRabbit
New Features
Documentation