fix(validation): flag hyphenated URL version segments#369
Merged
hdamker merged 1 commit intoJul 8, 2026
Conversation
The feature-file (P-025) and server-URL (P-004) version checks captured the segment with a `v[a-z0-9.]+` charset, so a hyphenated segment like `v0.1-eri` matched only `v0.1`, the trailing `-` failed the match, and the line was silently skipped — a false negative that let the pre-snapshot wip check block a snapshot the PR check had passed. Both checks now share one helper that captures the whole path segment after the api-name and compares it to the expected segment, so any deviation is flagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
The feature-file scenario-step version check (P-025) and the server-URL version check (P-004) captured the URL version segment with a
v[a-z0-9.]+charset. A hyphenated segment likev0.1-erimatched onlyv0.1; the trailing-then failed the match, so P-025 silently skipped the line and P-004 reported a misleadingno recognisable version segment. A valid CAMARA version segment never contains a hyphen (build_version_segmentstrips them), so such a segment is always malformed and should error.The effect was a divergence: a malformed segment passed PR-time validation but was caught by the pre-snapshot wip check, blocking snapshot creation with errors that never appeared on the PR.
Both checks now share one helper that captures the whole path segment after the api-name and compares it to the expected segment, so any deviation — hyphen, typo, bare
wip, or a wrong version — is flagged, and the two version checks cannot drift.Which issue(s) this PR fixes:
Fixes #367
Special notes for reviewers:
dedicated-network-areas.feature: the threev0.1-erilines now flag, matching what the snapshot gate reported (fixed content-side in Correcting URL in API test definition file DedicatedNetworks#127).qod) that did not match their URL path (/quality-on-demand/…); the URLs are corrected so the test data reflects the real shape where the URL api-name matches the API.Changelog input
Additional documentation
This section can be blank.