fix(validation): catch hyphenated URL version segments#368
Closed
LarryHu0217 wants to merge 1 commit into
Closed
Conversation
|
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
Updates URL version-segment matching so validation captures the complete version path segment after an API-shaped segment, including malformed values such as
v0.1-eri.This makes P-025 report malformed feature-file URL versions instead of silently skipping them, and makes P-004 report malformed server URL version segments as mismatches rather than as missing/unrecognisable versions.
Which issue(s) this PR fixes:
Fixes #367
Special notes for reviewers:
The change keeps URLs without any version-like segment in the existing “no recognisable version” path. The new behavior only applies when the segment is version-like (
v...orwip) but malformed or unexpected.Changelog input
Additional documentation
This section can be blank.