fix: honor settings auto-accept on new sessions - #47104
Open
RaviTharuma wants to merge 3 commits into
Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47096
Type of change
What does this PR do?
Desktop Settings can turn Auto-accept permissions on for a directory, but a new session only copied the prompt-bar toggle. If that toggle was off, the first message still prompted.
New sessions now also inherit
isAutoAcceptingDirectory(projectDirectory)from Settings.How did you verify your code works?
Added
applies settings directory auto-accept to new sessions when the prompt toggle is offinpackages/app/src/components/prompt-input/submit.test.ts. Ran that file underbun test --conditions=solid --preload ./happydom.ts; the suite hits a pre-existingtoasterexport error in this worktree, same as importing the existing tests.Screenshots / recordings
N/A — permission wiring, no layout change.
Checklist