Skip to content

fix(app): make auto-accept permissions app-level - #47320

Draft
ProdigyRahul wants to merge 2 commits into
anomalyco:devfrom
ProdigyRahul:global-auto-accept
Draft

fix(app): make auto-accept permissions app-level#47320
ProdigyRahul wants to merge 2 commits into
anomalyco:devfrom
ProdigyRahul:global-auto-accept

Conversation

@ProdigyRahul

@ProdigyRahul ProdigyRahul commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

closes #37617

related to #38289

Type of change

  • bug fix
  • new feature
  • refactor / code improvement
  • documentation

What does this PR do?

auto-accept permissions is now one saved app setting. it can be turned on from the home screen before a session is open, and the same choice is used for every session. failed automatic replies are retried, and pending requests found after reconnecting are approved.

the v2 app already has this behavior in #44608. this brings the same behavior to the desktop dev app.

How did you verify your code works?

  • ran bun typecheck in packages/app
  • ran bun run typecheck:e2e in packages/app
  • passed the repository pre-push typecheck
  • launched the desktop dev app
  • confirmed the setting works on the home screen with no session open
  • added regression coverage for home settings, pending requests, and reply retries

Screenshots / recordings

before

before

after

after

Checklist

  • i have tested my changes locally
  • i have not included unrelated changes in this pr

@github-actions github-actions Bot added contributor needs:compliance This means the issue will auto-close after 2 hours. labels Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on the search results, I found a related PR that may be relevant:

Related PR:

This PR is likely related because it addresses auto-accept permissions on new sessions, which is closely aligned with the current PR's goal of making auto-accept permissions an app-level setting that applies across sessions.

Other related PRs that address auto-accept permissions (but appear to be older/different scopes):

The most important one to check is #47104, as it appears to be addressing the same feature area very recently.

@ProdigyRahul
ProdigyRahul marked this pull request as ready for review September 4, 2026 16:01
@ProdigyRahul
ProdigyRahul marked this pull request as draft September 4, 2026 16:16
@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop v1.18.3 — "Auto-accept permissions" settings toggle permanently disabled (cursor: not-allowed)

1 participant