fix(app): auto-accept toggle fallback directory when no session - #48244
fix(app): auto-accept toggle fallback directory when no session#48244johnhenry030888 wants to merge 1 commit into
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found several related PRs addressing auto-accept settings functionality, but no current duplicate PRs. However, here are related PRs that address similar or adjacent concerns: Related PRs (not duplicates, but related to auto-accept settings):
These are all historical or adjacent fixes to auto-accept functionality, but PR #48244 appears to be addressing a specific gap (fallback directory when no session is open) that isn't currently covered by an open PR. |
03159e8 to
6564eac
Compare
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
Fixes #48237.
The Settings → General auto-accept switch is greyed out with no session open because
createPermissionScopeControllerresolves its directory only from session lineage. This adds afallbackDirectory(session lineage first, route directory otherwise) and threadsdirectory()fromDialogSettingsthroughSettingsGeneralV2. The switch stays disabled only when no directory is known at all.Includes e2e coverage (
remote-session-settings.spec.ts). Tested against v1.18.29.