Skip to content

fix(app): auto-accept toggle fallback directory when no session - #48244

Closed
johnhenry030888 wants to merge 1 commit into
anomalyco:devfrom
johnhenry030888:pr/002-auto-accept-toggle
Closed

fix(app): auto-accept toggle fallback directory when no session#48244
johnhenry030888 wants to merge 1 commit into
anomalyco:devfrom
johnhenry030888:pr/002-auto-accept-toggle

Conversation

@johnhenry030888

Copy link
Copy Markdown

Fixes #48237.

The Settings → General auto-accept switch is greyed out with no session open because createPermissionScopeController resolves its directory only from session lineage. This adds a fallbackDirectory (session lineage first, route directory otherwise) and threads directory() from DialogSettings through SettingsGeneralV2. The switch stays disabled only when no directory is known at all.

Includes e2e coverage (remote-session-settings.spec.ts). Tested against v1.18.29.

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found several related PRs addressing auto-accept settings functionality, but no current duplicate PRs. However, here are related PRs that address similar or adjacent concerns:

Related PRs (not duplicates, but related to auto-accept settings):

  1. PR fix: honor settings auto-accept on new sessions #47104 - fix: honor settings auto-accept on new sessions

    • May share similar logic for handling auto-accept across sessions
  2. PR fix(app): make auto-accept permissions app-level #47320 - fix(app): make auto-accept permissions app-level

    • Related to app-level auto-accept permission handling
  3. PR fix(app): reflect global permission:allow in Settings auto-accept toggle #46226 - fix(app): reflect global permission:allow in Settings auto-accept toggle

    • Related to syncing Settings UI with global permissions state
  4. PR fix(app): enable scoped auto-accept settings #43193 - fix(app): enable scoped auto-accept settings

    • Related to directory-scoped auto-accept settings
  5. PR fix(app): enable directory auto-accept settings #42331 - fix(app): enable directory auto-accept settings

    • Similar directory-level auto-accept functionality

These are all historical or adjacent fixes to auto-accept functionality, but PR #48244 appears to be addressing a specific gap (fallback directory when no session is open) that isn't currently covered by an open PR.

@johnhenry030888
johnhenry030888 force-pushed the pr/002-auto-accept-toggle branch from 03159e8 to 6564eac Compare September 9, 2026 22:55
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 10, 2026
@github-actions github-actions Bot closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(app): auto-accept toggle disabled when no session is open

1 participant