Skip to content

fix: FrappeFilterList type hint#53

Merged
barredterra merged 2 commits into
version-15from
type-hint
Jul 13, 2026
Merged

fix: FrappeFilterList type hint#53
barredterra merged 2 commits into
version-15from
type-hint

Conversation

@barredterra

Copy link
Copy Markdown
Member

No description provided.

@barredterra

Copy link
Copy Markdown
Member Author

@Mergifyio backport version-16 develop

@mergify

mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

backport version-16 develop

✅ Backports have been created

Details

@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Pure type annotation change with no runtime behaviour modifications — safe to merge.

The change only touches type hints. FrappeFilterList accurately models Frappe's filter-row structure, including list-valued elements for in/not in operators, and no logic paths are altered.

No files require special attention.

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class Scalar {
        <<type alias>>
        str | int | float | bool | None
    }
    class FrappeFilterList {
        <<type alias>>
        list[list[Scalar | list[Scalar]]]
    }
    class ask_alyfToolset {
        +get_list(doctype, fields, filters: dict | FrappeFilterList | None, ...)
        +get_count(doctype, filters: dict | FrappeFilterList | None)
        +get_value(doctype, fieldname, filters: dict | FrappeFilterList | str | None)
    }
    FrappeFilterList --> Scalar : element type
    ask_alyfToolset --> FrappeFilterList : uses
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
classDiagram
    class Scalar {
        <<type alias>>
        str | int | float | bool | None
    }
    class FrappeFilterList {
        <<type alias>>
        list[list[Scalar | list[Scalar]]]
    }
    class ask_alyfToolset {
        +get_list(doctype, fields, filters: dict | FrappeFilterList | None, ...)
        +get_count(doctype, filters: dict | FrappeFilterList | None)
        +get_value(doctype, fieldname, filters: dict | FrappeFilterList | str | None)
    }
    FrappeFilterList --> Scalar : element type
    ask_alyfToolset --> FrappeFilterList : uses
Loading

Reviews (2): Last reviewed commit: "fix: support in/not in operators" | Re-trigger Greptile

Comment thread ask_alyf/ask_alyf/toolset.py Outdated
greptile-apps[bot]
greptile-apps Bot previously approved these changes Jul 13, 2026
@barredterra
barredterra merged commit 0bcc08d into version-15 Jul 13, 2026
5 checks passed
@barredterra
barredterra deleted the type-hint branch July 13, 2026 03:14
barredterra added a commit that referenced this pull request Jul 13, 2026
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
barredterra added a commit that referenced this pull request Jul 13, 2026
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant