Skip to content

fix: FrappeFilterList type hint (backport #53)#55

Merged
barredterra merged 1 commit into
developfrom
mergify/bp/develop/pr-53
Jul 13, 2026
Merged

fix: FrappeFilterList type hint (backport #53)#55
barredterra merged 1 commit into
developfrom
mergify/bp/develop/pr-53

Conversation

@mergify

@mergify mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of pull request #53 done by [Mergify](https://mergify.com).

@mergify mergify Bot mentioned this pull request Jul 13, 2026
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This is a narrowly scoped type-hint-only change with no runtime behavior modifications; it is safe to merge.

The backport is an exact match to the original PR #53: two type aliases are added and three method signatures are updated. No logic changes, no new dependencies, and the modern union syntax is valid under the project's Python ≥3.14 requirement. The FrappeFilterList definition correctly handles both simple scalar rows and list-valued operands (e.g. in).

No files require special attention.

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class Scalar {
        <<type alias>>
        str | int | float | bool | None
    }
    class FrappeFilterList {
        <<type alias>>
        list[list[Scalar | list[Scalar]]]
    }
    class ask_alyfToolset {
        +get_list(doctype, fields, filters: dict | FrappeFilterList | None, ...)
        +get_count(doctype, filters: dict | FrappeFilterList | None)
        +get_document_field(doctype, fieldname, filters: dict | FrappeFilterList | str | None)
    }
    FrappeFilterList --> Scalar : element type
    ask_alyfToolset --> FrappeFilterList : uses
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
classDiagram
    class Scalar {
        <<type alias>>
        str | int | float | bool | None
    }
    class FrappeFilterList {
        <<type alias>>
        list[list[Scalar | list[Scalar]]]
    }
    class ask_alyfToolset {
        +get_list(doctype, fields, filters: dict | FrappeFilterList | None, ...)
        +get_count(doctype, filters: dict | FrappeFilterList | None)
        +get_document_field(doctype, fieldname, filters: dict | FrappeFilterList | str | None)
    }
    FrappeFilterList --> Scalar : element type
    ask_alyfToolset --> FrappeFilterList : uses
Loading

Reviews (1): Last reviewed commit: "fix: FrappeFilterList type hint (#53)" | Re-trigger Greptile

@barredterra
barredterra merged commit 4bd8de6 into develop Jul 13, 2026
5 checks passed
@barredterra
barredterra deleted the mergify/bp/develop/pr-53 branch July 13, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant