Skip to content

fix: FrappeFilterList type hint (backport #53)#54

Merged
barredterra merged 1 commit into
version-16from
mergify/bp/version-16/pr-53
Jul 13, 2026
Merged

fix: FrappeFilterList type hint (backport #53)#54
barredterra merged 1 commit into
version-16from
mergify/bp/version-16/pr-53

Conversation

@mergify

@mergify mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of pull request #53 done by [Mergify](https://mergify.com).

@mergify mergify Bot mentioned this pull request Jul 13, 2026
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the change is purely additive type annotations with no runtime effect.

The backport introduces two type aliases and updates three method signatures. No logic, data flow, or runtime behavior is altered. The FrappeFilterList type correctly models Frappe's filter format including nested list values for IN operators. The change is minimal and matches the original PR's intent.

No files require special attention.

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class Scalar {
        <<TypeAlias>>
        str | int | float | bool | None
    }
    class FrappeFilterList {
        <<TypeAlias>>
        list[list[Scalar | list[Scalar]]]
    }
    class ask_alyfToolset {
        +get_list(doctype, fields, filters: dict | FrappeFilterList | None, ...)
        +get_count(doctype, filters: dict | FrappeFilterList | None)
        +get_doc_value(doctype, fieldname, filters: dict | FrappeFilterList | str | None)
    }
    FrappeFilterList --> Scalar : element type
    ask_alyfToolset --> FrappeFilterList : uses
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
classDiagram
    class Scalar {
        <<TypeAlias>>
        str | int | float | bool | None
    }
    class FrappeFilterList {
        <<TypeAlias>>
        list[list[Scalar | list[Scalar]]]
    }
    class ask_alyfToolset {
        +get_list(doctype, fields, filters: dict | FrappeFilterList | None, ...)
        +get_count(doctype, filters: dict | FrappeFilterList | None)
        +get_doc_value(doctype, fieldname, filters: dict | FrappeFilterList | str | None)
    }
    FrappeFilterList --> Scalar : element type
    ask_alyfToolset --> FrappeFilterList : uses
Loading

Reviews (1): Last reviewed commit: "fix: FrappeFilterList type hint (#53)" | Re-trigger Greptile

@barredterra
barredterra merged commit 7e75815 into version-16 Jul 13, 2026
5 checks passed
@barredterra
barredterra deleted the mergify/bp/version-16/pr-53 branch July 13, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant