Add card DOM data attributes to printing-tag candidate buttons - #6
Merged
Merged
Conversation
Candidate printing buttons in the "Who's That Planeswalker?" queue and picker carried none of the documented card DOM API attributes, making them invisible to tooling built against that contract. Adds getPrintingCandidateDataAttributes (a PrintingCandidate-shaped sibling to getCardDataAttributes) and spreads it onto both call sites. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
Landed directly on master (e2811ed) per this repo's standing direct-push workflow. |
WilfordGrimley
temporarily deployed
to
github-pages
July 12, 2026 21:04 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrintingTagQueue.tsx) and picker (PrintingTagPicker.tsx) carried none of the documented card DOM API attributes (frontend/docs/dom-api.md), making them invisible to tooling built against that contract.getPrintingCandidateDataAttributesinfrontend/src/common/cardDom.ts(aPrintingCandidate-shaped sibling togetCardDataAttributes), spread onto the candidate<CandidateButton>/<Button>in both call sites, sourced from the card currently being tagged plus thePrintingCandidatefor each button.PrintingTagPickergained acardNameprop since it previously only hadcardIdentifier;CardDetailedViewModal.tsxnow passescardDocument.namethrough.dom-api.md, calling out explicitly that this is a different kind of hit than a normal card slot —data-card-namenames the card being tagged, not necessarily what the candidate depicts.Test plan
npx tsc --noEmitcleannpx eslinton changed files — 0 errors (pre-existing<img>-vs-next/imagewarnings only)npx prettier@2.7.1 --checkcleannpx playwright test tests/PrintingTagQueue.spec.ts tests/PrintingTagPicker.spec.ts --project=chromium— 7/7 passed (new assertions cover both files), including new tests assertingdata-card-name/data-card-identifier/data-card-set-code/data-card-collector-numberland on candidate buttons with correct values🤖 Generated with Claude Code