Skip to content

fix: prim_compute_bbox return annotation omits midpoint tuple - #55

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/prim-utils-98f43e9d
Open

fix: prim_compute_bbox return annotation omits midpoint tuple#55
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/prim-utils-98f43e9d

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in exts/omni.ext.mobility_gen/omni/ext/mobility_gen/utils/prim_utils.py: prim_compute_bbox return annotation omits midpoint tuple.

Changes

  • exts/omni.ext.mobility_gen/omni/ext/mobility_gen/utils/prim_utils.py: prim_compute_bbox return annotation omits midpoint tuple.

Details

Before:

def prim_compute_bbox(prim: Usd.Prim, nested: bool = False) -> \
        tp.Tuple[tp.Tuple[float, float, float], tp.Tuple[float, float, float]]:
    """Computes the axis-aligned bounding box for a USD prim.
    
    Args:
        prim (Usd.Prim):  The USD prim to compute the bounding box of.

    Returns:
        Tuple[Tuple[float, float, float], Tuple[float, float, float]] The ((min_x, min_y, min_z), (max_x, max_y, max_z)) values of the bounding box.
    """

After:

def prim_compute_bbox(prim: Usd.Prim, nested: bool = False) -> \
        tp.Tuple[tp.Tuple[float, float, float], tp.Tuple[float, float, float], tp.Tuple[float, float, float]]:
    """Computes the axis-aligned bounding box for a USD prim.
    
    Args:
        prim (Usd.Prim):  The USD prim to compute the bounding box of.

    Returns:
        Tuple[Tuple[float, float, float], Tuple[float, float, float], Tuple[float, float, float]] The ((min_x, min_y, min_z), (max_x, max_y, max_z), (mid_x, mid_y, mid_z)) values of the bounding box.
    """

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant