Skip to content

fix: guard simulation edge cases - #330

Closed
galjos wants to merge 1 commit into
devfrom
fix/simulation-edge-guards
Closed

fix: guard simulation edge cases#330
galjos wants to merge 1 commit into
devfrom
fix/simulation-edge-guards

Conversation

@galjos

@galjos galjos commented Jul 28, 2026

Copy link
Copy Markdown
Member

Closes #329.

  • complete single-step progress without dividing by zero
  • handle zero-temperature resets and velocity rescaling explicitly
  • reject invalid cell-list sizes before allocation

Tests:

  • testProgressbar
  • testResetKinetics
  • testCelllist
  • testThermostat

@galjos
galjos requested review from 97gamjak and ape33 July 28, 2026 15:19
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.83%. Comparing base (262484e) to head (a146167).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #330      +/-   ##
==========================================
+ Coverage   89.81%   89.83%   +0.02%     
==========================================
  Files         293      293              
  Lines       11420    11444      +24     
  Branches     3600     3611      +11     
==========================================
+ Hits        10257    10281      +24     
  Misses       1122     1122              
  Partials       41       41              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pq-perf-bot

pq-perf-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 41.46M 41.46M -0.00%
boxTransforms 10.67M 10.67M +0.00%
constraints 11.38M 11.38M -0.00%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 15.33M 15.33M +0.00%
integrator 32.17M 32.17M -0.00%
kinetics 9.53M 9.53M +0.00%
linearAlgebra 2.07M 2.07M +0.00%
nonCoulombPairs 5.48M 5.48M -0.00%
shiftVector 5.81M 5.81M +0.00%
virial 11.64M 11.63M -0.07%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@galjos

galjos commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

Superseded by focused review units: #349 for single-step progress, #350 for zero-temperature rescaling, and #348 for cell-list sizing. This combined PR should not be merged.

@galjos galjos closed this Jul 28, 2026
@galjos
galjos deleted the fix/simulation-edge-guards branch August 3, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant