Decompose Fallout.Migrate into an IMigrationStep pipeline#507
Open
dennisdoomen wants to merge 1 commit into
Open
Decompose Fallout.Migrate into an IMigrationStep pipeline#507dennisdoomen wants to merge 1 commit into
dennisdoomen wants to merge 1 commit into
Conversation
dennisdoomen
force-pushed
the
improve-migration
branch
3 times, most recently
from
July 18, 2026 11:28
eabdaf5 to
8e7dcdc
Compare
Migration.Run() hard-coded four migration actions as private methods sharing private helpers, making it awkward to add the steps planned next. Split into: - Common/ -- MigrationContext (plain data), Summary, RewriteResult, IMigrationStep, and MigrationFileOperations (shared EnumerateFiles / ApplyRewrite / RelativePath helpers) - Steps/ -- one class per step (ResolveFalloutVersionStep, RewriteCsprojsStep, RewriteCsFilesStep, RewriteBootstrapScriptsStep, RenameNukeDirectoryStep), each paired with the rewriter it drives (CsprojRewriter, CodeRewriter, ScriptRewriter) Migration.Run() now just builds a MigrationContext and iterates a fixed, ordered step list. Adding a future step is one new class plus one line in that list. No behavior change; MigrationIntegrationSpecs pass unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
dennisdoomen
force-pushed
the
improve-migration
branch
from
July 18, 2026 11:29
8e7dcdc to
d640760
Compare
dennisdoomen
marked this pull request as ready for review
July 18, 2026 11:29
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures
fallout-migrate's migration logic into a step pipeline so new migration steps (more are coming soon) can be added without growing one class.What changed
Common/-- shared, behavior-free/static pieces:MigrationContext,Summary,RewriteResult,IMigrationStep,MigrationFileOperations(EnumerateFiles/ApplyRewrite/RelativePath)Steps/-- one class per migration step (ResolveFalloutVersionStep,RewriteCsprojsStep,RewriteCsFilesStep,RewriteBootstrapScriptsStep,RenameNukeDirectoryStep), each next to the rewriter it drives (CsprojRewriter,CodeRewriter,ScriptRewriter)Migration.Run()now just builds aMigrationContextand iterates a fixed, orderedIMigrationSteplist -- adding a step is one new class + one lineNo behavior change; internal-only, no public API touched.
Verification
dotnet test tests/Fallout.Migrate.Specs-- 22/22 pass.