Style fallout-migrate's banner and summary output with AnsiConsole#508
Draft
dennisdoomen wants to merge 1 commit into
Draft
Style fallout-migrate's banner and summary output with AnsiConsole#508dennisdoomen wants to merge 1 commit into
dennisdoomen wants to merge 1 commit into
Conversation
Replace the plain Console.WriteLine calls in MigrateCommand's banner and summary printing with Spectre.Console's AnsiConsole: bold banner, yellow dry-run notice and warnings, green completion messages, dimmed guide link. Interpolated values (paths, warning text) go through MarkupLineInterpolated so user-controlled content can't be misinterpreted as markup. Left Console.Error.WriteLine for the two error messages (stderr semantics matter for piping/exit codes) and the TextWriter-based per-file/per-rename logging in the Steps/Common classes untouched -- that log stays plain text so MigrationIntegrationSpecs can keep capturing it via TextWriter.Null without a console. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
|
mind adding a screenshot to the PR for future reference? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #507. Replaces the plain Console.WriteLine calls in MigrateCommand's banner and summary printing with Spectre.Console's AnsiConsole.
What changed
Left untouched:
No behavior change; internal-only, no public API touched.
Verification
dotnet test tests/Fallout.Migrate.Specs -- 22/22 pass.