Recognizes version variables and updates the version accordingly#478
Open
IT-VBFK wants to merge 3 commits into
Open
Recognizes version variables and updates the version accordingly#478IT-VBFK wants to merge 3 commits into
IT-VBFK wants to merge 3 commits into
Conversation
ITaluone
force-pushed
the
fix/csproj-convert-version-var
branch
from
2e73450 to
1391641
Compare
ITaluone
added
enhancement
IT-VBFK
force-pushed
the
fix/csproj-convert-version-var
branch
from
f157a46 to
40c5ed9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Fallout.Migrate’s .csproj rewrite logic to handle projects that pin Fallout/Nuke package versions via MSBuild properties (e.g., Version="$(NukeVersion)"), aligning with issue #477’s migration expectations.
Changes:
- Refines the “inline literal version” rewrite to avoid consuming
Version="$(...)"so variable-based versions can be handled separately. - Adds a new pass that discovers version variables used by PackageReferences and bumps the corresponding property values to the target Fallout version.
- Extends specs to cover
NukeVersion→FalloutVersionrenaming and arbitrary version-variable bumping behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Fallout.Migrate/CsprojRewriter.cs |
Adds variable-aware version handling and bumps property-based versions to the target Fallout version. |
tests/Fallout.Migrate.Specs/CsprojRewriterSpecs.cs |
Adds/adjusts specs to validate migration behavior for version variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChrisonSimtian
requested changes
Jul 12, 2026
IT-VBFK
force-pushed
the
fix/csproj-convert-version-var
branch
from
da9ece9 to
d3fc9b9
Compare
ITaluone
force-pushed
the
fix/csproj-convert-version-var
branch
from
d3fc9b9 to
f3ff5e1
Compare
Collaborator
|
@copilot review |
ITaluone
force-pushed
the
fix/csproj-convert-version-var
branch
from
f3ff5e1 to
2fb66d4
Compare
IT-VBFK
changed the title
IT-VBFK
force-pushed
the
fix/csproj-convert-version-var
branch
from
2fb66d4 to
51c3c6b
Compare
ITaluone
force-pushed
the
fix/csproj-convert-version-var
branch
from
51c3c6b to
0550dd3
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ITaluone
force-pushed
the
fix/csproj-convert-version-var
branch
from
0550dd3 to
8e438a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #477