feat: show connection status and last sync time for bank accounts and cards - #93852
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| // The card should be grouped to a specific domain and such domain already exists in a assignedCardsGrouped | ||
| if (assignedCardsGrouped.some((item) => item.isGroupedCardDomain && item.description === card.domainName) && !isAdminIssuedVirtualCard) { | ||
| const domainGroupIndex = assignedCardsGrouped.findIndex((item) => item.isGroupedCardDomain && item.description === card.domainName); | ||
| const assignedCardsGroupedItem = assignedCardsGrouped.at(domainGroupIndex); | ||
| if (domainGroupIndex >= 0 && assignedCardsGroupedItem) { | ||
| assignedCardsGroupedItem.errors = {...assignedCardsGrouped.at(domainGroupIndex)?.errors, ...card.errors}; | ||
| if ( | ||
| card.fraud === CONST.EXPENSIFY_CARD.FRAUD_TYPES.DOMAIN || | ||
| card.fraud === CONST.EXPENSIFY_CARD.FRAUD_TYPES.INDIVIDUAL || | ||
| Object.keys(assignedCardsGroupedItem.errors).length > 0 | ||
| ) { | ||
| assignedCardsGroupedItem.brickRoadIndicator = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR; | ||
| } | ||
| } | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Are you able to test this domain flow? I am not sure we should remove this entire domain card grouping logic.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 987214eef9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ReviewThanks for the PR! The feature looks well-organized, but CI is currently red across 4 checks (typecheck, ESLint, test, checklist) and every failure traces back to this diff. These are all blocking and need to be addressed before review can proceed. 🔴 Must fix (blocking CI)1. Translation keys only added to 2. 3. 4. Nested ternaries (ESLint
Extract these into helper functions or 🟡 Worth a look (logic/design — please verify)Details
Note on pushing a fixI'm not the PR author or an assignee, so I can't push these fixes to the branch myself. The author can knock out items 1–4 to get CI green; if you'd like me to take a pass at them, add me as an assignee and reply with |
|
@mkhutornyi, I am checking all feedback in order. thanks. |
|
I know it's hard to test all cases of bank account and card flow so in Tests steps, please add hardcoded mock Onyx data which has all cases shown in design. It should have 9 bank/card connections below:
|
|
How about adding beta until this feature is fully QA'ed by internal team and QA? So non-beta users still see old UI. |
…r-bank-accounts-and-cards
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.46-0 🚀
|
Help site review — changes required ✅I reviewed the changes in this PR against the help articles under Draft help-site PR: #97389 ( What it documents in the Manage Personal Cards article:
Scope notes & why it's a draft
@marufsharifi, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@marufsharifi I am not sure we can check all flows from this PR, especially Card Flows. Could you please check this internally? Let me know if I missed anything. Thank you in advance |
|
@izarutskaya were you able to check the bank account flows? |
|
Should we ship this to production? It looks like it wasn't tested on staging at all. 🤔 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
BUG: non-U.S. business bank account shows Pending for partially set up accountSteps
Expected behaviorWe say the account is incomplete, with the option to complete setup. Actual behaviorWe say the account is pending with an option to confirm test transactions. However, there is no test transaction step for non-U.S. business bank accounts that only applies to U.S. Business Bank accounts. I think the issue here is that non-U.S. business bank accounts are put in the 2026-08-03_12-11-22.mp4 |
Yeah, most likely |
|
@joekaufmanexpensify, just wanted to confirm—would you like me to open a follow-up PRs to address the bug you found? Thanks! |
|
@joekaufmanexpensify do you mind creating (or asking Melvin to create) issues per each bug you found and assign @marufsharifi and me for tracking? |
Yep. I don't think we should consider this issue done until these other bugs are fixed. These are all things I expect QA would have found had they tested before this went to production.
Thoughts on just using a bulleted checklist on the original issue in a comment, with each item linking back to one of the bug reports? That way, each PR links back to the original issue, making it clear that it's associated with it. Not super passionate though. If it's easier for you guys to have separate issues, I'm fine with that and can have Melvin create them. |
|
I'm happy to open the PR and link it to the relevant issue comment in this PR. @mkhutornyi agree? |
yes |
|
Great, thanks, appreciate both of your help. I aggregated the bugs I found here. |







Explanation of Change
This PR adds connection health visibility for bank accounts and cards in the wallet/payment connection surfaces.
For bank accounts, it updates the displayed statuses and related RBR/action copy so users can see whether an account is Active, Incomplete, Pending, Verifying, or Locked, and take the appropriate existing action when needed.
For cards, it adds Active/Inactive connection status, last sync information for direct-feed and personal cards, and the issue-specific RBR/action behavior for broken personal card and company card connections.
Fixed Issues
$ #91300
PROPOSAL:
Tests
Precondition:
walletConnectionStatusbeta account.Card Flows
Settings > Wallet > Cards.ActiveandSynced [relative date].Settings > Wallet > Cards.ActiveandNever synced.Settings > Wallet > Cards.Inactive,Please fix this connection, and theFixbutton.Settings > Wallet > Cards.Inactive,Please fix this connection in company cards, and noFixbutton.Settings > Wallet > Cards.Inactive,Please ask an admin to fix this connection, and noFixbutton orcompany cardslink.Bank Account Flows
Settings > Wallet > Bank accounts.Activewith no RBR/action.Settings > Wallet > Bank accounts.Incomplete,Finish adding bank account, and theFinishbutton.Settings > Wallet > Bank accounts.Pending,Please confirm test transactions, and theConfirmbutton.Settings > Wallet > Bank accounts.Verifyingwith the tooltipWe're reviewing your documentationand no RBR/action.Settings > Wallet > Bank accounts.Locked,This account requires attention, and theUnlockbutton.Workflow Bank Account Flows
Settings > Workspaces > [Workspace] > Workflows.ActiveActivewith no RBR/action.IncompleteIncomplete,Finish adding bank account, andFinish.PendingPending,Please confirm test transactions, andConfirm.VerifyingVerifyingwith the tooltipWe're reviewing your documentationand no RBR/action.LockedLocked,This account requires attention, andUnlock.Offline tests
Same as tests
QA Steps
Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Card Flows
One
Two
Three
Four
Five
Bank Account Flows
One
Two
Three
Four
Five
Workflow Bank Account Flows
One
Android: mWeb Chrome
Card Flows
One
Two
Three
Four
Five
Bank Account Flows
One
Two
Three
Four
Five
Workflow Bank Account Flows
One
iOS: Native
Card Flows
One
Two
Three
Four
Five
Bank Account Flows
One
Two
Three
Four
Five
Workflow Bank Account Flows
One
iOS: mWeb Safari
Card Flows
One
Two
Three
Four
Five
Bank Account Flows
One
Two
Three
Four
Five
Workflow Bank Account Flows
One
MacOS: Chrome / Safari
Card Flows
One
Two
Three
Four
Five
Bank Account Flows
One
Two
Three
Four
Screen.Recording.2026-06-20.at.12.06.17.AM.mov
Five
Workflow Bank Account Flows
One