[HOLD 91300] Support Validation_Failed bank account - #97962
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Validation_Failed bank account
Yeah, I think you are right. |
…idation-failed-bank-account
I think that's out of scope of this PR and also not a blocker |
Agreed. 👍 |
|
I'm not sure that the main content should change position when the error appears 2026-08-12.15.55.15.mov |
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
I found two accounts in the correct state. I tried to view them on the ad hoc build, but not seeing the action message on the bank account row on wallet in either case. I think the issue might be that the new front end error pattern added in #93852 is still gated behind the |
|
Normally, we have a tool we can use to add accounts to a beta, but I'm not seeing this one even listed there. |
|
Can we kill walletconnectionstatus? |
|
That beta is frontend only so we can't provision via the beta tool. Asking here Update: They are removing it soon after the followup bugs are addressed |
Validation_Failed bank accountValidation_Failed bank account
Explanation of Change
Show the right RBR and action for
Validation_Failedbank accounts with either insufficient funds or blocked debit error.Fixed Issues
$ #90830
PROPOSAL:
Tests
Precondition:
VALIDATION_FAILEDstate bank account with insufficient funds/debit blocked NOC code (TODO)PendingbadgeTest transactions failed due to insufficient fundsRBRFixFix bank accountRHP opens sayingTest transactions failed due to insufficient funds...Resend transactionsbutton is disabled in offlineResend transactionsGot itPlease confirm test transactionsRBR andConfirmbuttonIn the next 1-2 business days, "Expensify Inc" will send 3 small test transactions to your bank accountYour bank blocked test transactions to this accountRBR andYour bank blocked the test transactions to this account. Please have them whitelist Expensify's ACH IDsinFix bank accountRHPPay with business bank accountOffline tests
None
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-07.at.02.19.33.mov
Screen.Recording.2026-08-07.at.02.54.25.mov