Repository navigation
Move the list-screen chrome and panel dialogs into the framework - #5
Merged
Merged
Conversation
This was referenced Oct 21, 2026
Use the Options Menu screen chrome, list rows and scroll arrows
DefKorns/om-gamepad-remapping-tool#3
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the helpers that every list screen kept as its own lambdas into
src/framework, and moves Save Manager and Module Uninstaller onto them.list_screen:ScreenChrome,DrawFooterDivider,DrawListRow,NoteBox,ScrollArrows.DrawLinesCenteredmoves intotext_layout.panel_dialog:PanelDialog(Acknowledge / Confirm / ConfirmDestructive),DialogResult,ShowBusy,DropPendingInput.Behaviour changes:
DropPendingInputresets every button after blocking work, not just A and B.Tested: plain and compat builds,
tests/run_tests.sh. On the console, framebuffer dumps showed no pixel changes from the step 1 extraction, and every SM/MU dialog was checked with real buttons.The add-ons (Favorites, Theme Selector, Gamepad tool) move over after the OM submodule bump.