Repository navigation
Use the Options Menu screen chrome and scroll arrows - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Theme Manager onto the shared Options Menu framework (DefKorns/OptionsMenu#5, #6) and bumps the Options Menu submodule to 53e75ae.
ScreenChrome::DrawFrame(). The section title stays local, because the grid draws it smaller and at a variable position.Command::RunCommandandRunDownloadScreentake the sameScreenChrome, replacingModernChrome, which the Options Menu removed.ScrollArrows, in the same place as the other list screens. The grid keeps its own arrow positions but draws the chevron image instead of a^glyph.texture_utilsdrops its copies ofTextWidthandTruncateToWidthin favour of the framework'stext_layout, which gives the same results. Both would otherwise be linked in.Tested on the console: the compat build was checked on the list, Folder Themes and the theme grid, plus a command and a theme download.