Repository navigation
Use the Options Menu screen chrome, list rows and scroll arrows - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the remapper screen onto the shared Options Menu framework (DefKorns/OptionsMenu#5, #6) and bumps the Options Menu submodule to 53e75ae.
ScreenChrome, and the save notice lines up withSectionTitleRect().DrawListRow, so the selection box and separators match the other list screens.ScrollArrows, in the same place as the other screens, instead of next to the first and last visible rows.Tested on the console: the compat build was checked with real buttons (scroll through the whole list and back, selection always visible, notice next to the title). Framebuffer dumps showed the first screen unchanged apart from the arrow and row geometry.